Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 302433013: Instant interactive_ui_tests should wait for main frame load. (Closed)

Created:
6 years, 7 months ago by kouhei (in TOK)
Modified:
6 years, 6 months ago
Reviewers:
brettw, kmadhusu
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered, haraken, adamk
Visibility:
Public.

Description

Instant interactive_ui_tests should wait for main frame load. Before this patch, instant search tests didn't wait for the main frame load before executing javascript, resulting in running javascript in incomplete document. This patch is to allow reland of v8::context patch in blink: https://codereview.chromium.org/263583002/ It seems that the valid document were luckily there when we run these tests before the blink CL, but the blink CL changes the timeline so it fails on these tests. BUG=368548, 368555 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273996

Patch Set 1 #

Patch Set 2 : only change first wait to wait for frame load #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/search/instant_test_utils.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/search/instant_test_utils.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
kouhei (in TOK)
Would you take a look?
6 years, 7 months ago (2014-05-28 05:09:30 UTC) #1
kouhei (in TOK)
On 2014/05/28 05:09:30, kouhei wrote: > Would you take a look? Sorry. Looks like the ...
6 years, 6 months ago (2014-05-28 08:30:41 UTC) #2
kouhei (in TOK)
PTAL. New fix seems to be working.
6 years, 6 months ago (2014-05-29 05:01:57 UTC) #3
kmadhusu
On 2014/05/29 05:01:57, kouhei wrote: > PTAL. New fix seems to be working. lgtm.
6 years, 6 months ago (2014-05-29 19:55:12 UTC) #4
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 6 months ago (2014-05-30 00:46:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/302433013/20001
6 years, 6 months ago (2014-05-30 00:48:07 UTC) #6
kouhei (in TOK)
The CQ bit was unchecked by kouhei@chromium.org
6 years, 6 months ago (2014-05-30 01:03:36 UTC) #7
kouhei (in TOK)
On 2014/05/30 01:03:36, kouhei wrote: > The CQ bit was unchecked by mailto:kouhei@chromium.org brettw: Would ...
6 years, 6 months ago (2014-05-30 01:24:37 UTC) #8
brettw
lgtm
6 years, 6 months ago (2014-05-30 23:51:39 UTC) #9
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 6 months ago (2014-05-31 03:19:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/302433013/20001
6 years, 6 months ago (2014-05-31 03:22:19 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 03:45:03 UTC) #12
Message was sent while issue was closed.
Change committed as 273996

Powered by Google App Engine
This is Rietveld 408576698