Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3309)

Unified Diff: chrome/browser/ui/search/instant_extended_interactive_uitest.cc

Issue 302433013: Instant interactive_ui_tests should wait for main frame load. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: only change first wait to wait for frame load Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/search/instant_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/search/instant_extended_interactive_uitest.cc
diff --git a/chrome/browser/ui/search/instant_extended_interactive_uitest.cc b/chrome/browser/ui/search/instant_extended_interactive_uitest.cc
index bfe80592c30e096a487d4f07610f857738af2ebe..e6bd93a05ffbc5e633fa1e4019c0d59a490fa8cb 100644
--- a/chrome/browser/ui/search/instant_extended_interactive_uitest.cc
+++ b/chrome/browser/ui/search/instant_extended_interactive_uitest.cc
@@ -359,7 +359,7 @@ IN_PROC_BROWSER_TEST_F(InstantExtendedTest, SearchReusesInstantTab) {
chrome::NOTIFICATION_INSTANT_TAB_SUPPORT_DETERMINED,
content::NotificationService::AllSources());
SetOmniboxText("flowers");
- PressEnterAndWaitForNavigation();
+ PressEnterAndWaitForFrameLoad();
observer.Wait();
// Just did a regular search.
@@ -407,7 +407,7 @@ IN_PROC_BROWSER_TEST_F(InstantExtendedTest,
chrome::NOTIFICATION_INSTANT_TAB_SUPPORT_DETERMINED,
content::NotificationService::AllSources());
SetOmniboxText("flowers");
- PressEnterAndWaitForNavigation();
+ PressEnterAndWaitForFrameLoad();
observer_1.Wait();
// Just did a regular search.
@@ -962,7 +962,7 @@ IN_PROC_BROWSER_TEST_F(InstantExtendedTest, Referrer) {
// Type a query and press enter to get results.
SetOmniboxText("query");
- PressEnterAndWaitForNavigation();
+ PressEnterAndWaitForFrameLoad();
// Simulate going to a result.
content::WebContents* contents =
« no previous file with comments | « no previous file | chrome/browser/ui/search/instant_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698