Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2742)

Unified Diff: chrome/browser/favicon/favicon_service.h

Issue 302433010: Pass an instance of FaviconClient to FaviconService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@latest2
Patch Set: Added include. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/favicon/favicon_handler_unittest.cc ('k') | chrome/browser/favicon/favicon_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_service.h
diff --git a/chrome/browser/favicon/favicon_service.h b/chrome/browser/favicon/favicon_service.h
index 26aeb85579cfd241469997035b57024e4098a117..5593d8b273d3de0bbd86386ddc9adab23543ccb7 100644
--- a/chrome/browser/favicon/favicon_service.h
+++ b/chrome/browser/favicon/favicon_service.h
@@ -15,6 +15,7 @@
#include "components/favicon_base/favicon_types.h"
#include "components/keyed_service/core/keyed_service.h"
+class FaviconClient;
class GURL;
class HistoryService;
struct ImportedFaviconUsage;
@@ -24,7 +25,9 @@ class Profile;
// backend behind the scenes.
class FaviconService : public KeyedService {
public:
- explicit FaviconService(Profile* profile);
+ // TODO(jif): Remove usage of Profile. http://crbug.com/378208.
+ // The FaviconClient must outlive the constructed FaviconService.
+ FaviconService(Profile* profile, FaviconClient* favicon_client);
virtual ~FaviconService();
@@ -219,6 +222,7 @@ class FaviconService : public KeyedService {
base::hash_set<MissingFaviconURLHash> missing_favicon_urls_;
HistoryService* history_service_;
Profile* profile_;
+ FaviconClient* favicon_client_;
// Helper function for GetFaviconImageForPageURL(), GetRawFaviconForPageURL()
// and GetFaviconForPageURL().
« no previous file with comments | « chrome/browser/favicon/favicon_handler_unittest.cc ('k') | chrome/browser/favicon/favicon_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698