Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5223)

Unified Diff: chrome/browser/favicon/favicon_handler_unittest.cc

Issue 302433010: Pass an instance of FaviconClient to FaviconService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@latest2
Patch Set: Added include. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_handler_unittest.cc
diff --git a/chrome/browser/favicon/favicon_handler_unittest.cc b/chrome/browser/favicon/favicon_handler_unittest.cc
index 4aa61b0378efa96190578b1f7142dad43b54d6ba..cbc3bb41e526ca33b146227bec9fda3c7d72d89f 100644
--- a/chrome/browser/favicon/favicon_handler_unittest.cc
+++ b/chrome/browser/favicon/favicon_handler_unittest.cc
@@ -3,6 +3,7 @@
// found in the LICENSE file.
#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/favicon/chrome_favicon_client.h"
#include "chrome/browser/favicon/favicon_handler.h"
#include "chrome/browser/favicon/favicon_service.h"
#include "chrome/browser/favicon/favicon_service_factory.h"
@@ -1405,7 +1406,9 @@ TEST_F(FaviconHandlerTest, TestKeepDownloadedLargestFavicon) {
}
static KeyedService* BuildFaviconService(content::BrowserContext* profile) {
- return new FaviconService(static_cast<Profile*>(profile));
+ FaviconClient* favicon_client =
+ new ChromeFaviconClient(static_cast<Profile*>(profile));
+ return new FaviconService(static_cast<Profile*>(profile), favicon_client);
}
static KeyedService* BuildHistoryService(content::BrowserContext* profile) {
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698