Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 3023018: Fix memory leaks in TopSites. (Closed)

Created:
10 years, 5 months ago by Nik Shkrob
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, brettw-cc_chromium.org, ben+cc_chromium.org, Alexander Potapenko, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org
Visibility:
Public.

Description

Fix memory leaks in TopSites. Revert http://codereview.chromium.org/3064004 BUG=50103 TEST=memory bots, heapcheck. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53653

Patch Set 1 #

Patch Set 2 : Real fix + unsuppress leaks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -34 lines) Patch
M chrome/browser/history/top_sites.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M tools/heapcheck/suppressions.txt View 1 chunk +0 lines, -14 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nik Shkrob
10 years, 5 months ago (2010-07-26 17:46:32 UTC) #1
brettw
10 years, 5 months ago (2010-07-26 17:47:27 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698