Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Issue 302243002: Revert 274063 "Revert of Properly prioritize the sources of an a..." (Closed)

Created:
6 years, 6 months ago by DaleCurtis
Modified:
6 years, 6 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 274063 "Revert of Properly prioritize the sources of an a..." > Revert of Properly prioritize the sources of an accessible name on Android. (https://codereview.chromium.org/303113003/) > > Reason for revert: > Broke android bots it looks like: > http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/20683 > > Original issue's description: > > Properly prioritize the sources of an accessible name on Android. > > > > This spec covers the right order: http://www.w3.org/TR/wai-aria-implementation > > > > Now Android basically matches Windows, the difference is that Android has > > to pick just one accessible name while Windows can have both a name and > > a description. > > > > There were existing cross-platform tests; I updated the Android > > expectations. > > > > BUG=359216 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274017 > > TBR=aboxhall@chromium.org,dmazzoni@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=359216 > > Review URL: https://codereview.chromium.org/304293006 TBR=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274088

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -20 lines) Patch
M trunk/src/content/browser/accessibility/browser_accessibility_android.cc View 1 chunk +20 lines, -3 lines 0 comments Download
M trunk/src/content/test/data/accessibility/button-name-calc-expected-android.txt View 1 chunk +5 lines, -6 lines 0 comments Download
M trunk/src/content/test/data/accessibility/checkbox-name-calc-expected-android.txt View 1 chunk +2 lines, -3 lines 0 comments Download
M trunk/src/content/test/data/accessibility/input-text-name-calc-expected-android.txt View 1 chunk +7 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
DaleCurtis
6 years, 6 months ago (2014-05-31 23:00:44 UTC) #1
DaleCurtis
6 years, 6 months ago (2014-05-31 23:00:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r274088.

Powered by Google App Engine
This is Rietveld 408576698