Issue 304293006: Revert of Properly prioritize the sources of an accessible name on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 304293006: Revert of Properly prioritize the sources of an accessible name on Android. (Closed)

Created:
6 years, 6 months ago by DaleCurtis

Modified:
6 years, 6 months ago

Reviewers:
dmazzoni, aboxhall

CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Revert of Properly prioritize the sources of an accessible name on Android. (https://codereview.chromium.org/303113003/) Reason for revert: Broke android bots it looks like: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/20683 Original issue's description: > Properly prioritize the sources of an accessible name on Android. > > This spec covers the right order: http://www.w3.org/TR/wai-aria-implementation > > Now Android basically matches Windows, the difference is that Android has > to pick just one accessible name while Windows can have both a name and > a description. > > There were existing cross-platform tests; I updated the Android > expectations. > > BUG=359216 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274017 TBR=aboxhall@chromium.org,dmazzoni@chromium.org NOTREECHECKS=true NOTRY=true BUG=359216 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274063

Patch Set 1 #

Created: 6 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -34 lines)			Patch
M	content/browser/accessibility/browser_accessibility_android.cc	View	1 chunk	+3 lines, -20 lines	0 comments	Download
M	content/test/data/accessibility/button-name-calc-expected-android.txt	View	1 chunk	+6 lines, -5 lines	0 comments	Download
M	content/test/data/accessibility/checkbox-name-calc-expected-android.txt	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/test/data/accessibility/input-text-name-calc-expected-android.txt	View	1 chunk	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

DaleCurtis

Created Revert of Properly prioritize the sources of an accessible name on Android.

6 years, 6 months ago (2014-05-31 22:08:50 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/304293006/1

6 years, 6 months ago (2014-05-31 22:09:14 UTC) #2

Message was sent while issue was closed.

Change committed as 274063

Expand Messages | Collapse Messages