Issue 302093012: Pepper: Refactor OpenManifestEntry.

Issue 302093012: Pepper: Refactor OpenManifestEntry. (Closed)

Created:
6 years, 6 months ago by teravest

Modified:
6 years, 6 months ago

Reviewers:
dmichael (off chromium)

CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pepper: Refactor OpenManifestEntry. This change pulls out more OpenManifestEntry code from service_runtime, making PPB_NaCl_Private a smallter interface, and preparing for pulling all of that logic out of the trusted plugin. BUG=239656 R=dmichael@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274530

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -111 lines)			Patch
M	components/nacl/renderer/ppb_nacl_private_impl.cc	View		6 chunks	+48 lines, -27 lines	0 comments	Download
M	ppapi/api/private/ppb_nacl_private.idl	View	1	2 chunks	+10 lines, -12 lines	0 comments	Download
M	ppapi/c/private/ppb_nacl_private.h	View	1	3 chunks	+11 lines, -12 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/service_runtime.cc	View		2 chunks	+6 lines, -50 lines	0 comments	Download
M	ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c	View	1 2	3 chunks	+4 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

lgtm https://codereview.chromium.org/302093012/diff/1/ppapi/api/private/ppb_nacl_private.idl File ppapi/api/private/ppb_nacl_private.idl (right): https://codereview.chromium.org/302093012/diff/1/ppapi/api/private/ppb_nacl_private.idl#newcode398 ppapi/api/private/ppb_nacl_private.idl:398: [in] PP_Bool helper_process, nit: is_helper_process?

6 years, 6 months ago (2014-06-02 21:55:29 UTC) #2

teravest

Committed patchset #3 manually as r274530 (presubmit successful).

6 years, 6 months ago (2014-06-03 15:02:38 UTC) #3

teravest

6 years, 6 months ago (2014-06-03 19:09:22 UTC) #4

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/318463002/ by teravest@chromium.org.

The reason for reverting is: This broke
NaClBrowserTestPnaclNonSfi.IrtManifestFile on linux 32. That test will have to
pass on the right trybot before landing. I'm not sure why it broke yet..

Expand Messages | Collapse Messages