Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Unified Diff: ppapi/c/private/ppb_nacl_private.h

Issue 302093012: Pepper: Refactor OpenManifestEntry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/api/private/ppb_nacl_private.idl ('k') | ppapi/native_client/src/trusted/plugin/service_runtime.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/c/private/ppb_nacl_private.h
diff --git a/ppapi/c/private/ppb_nacl_private.h b/ppapi/c/private/ppb_nacl_private.h
index bc253cc83f9ada7782d97faa01c4b8ce2f84aacd..01c207bbafa59ed5b807a6ca15d2c90b2853cb91 100644
--- a/ppapi/c/private/ppb_nacl_private.h
+++ b/ppapi/c/private/ppb_nacl_private.h
@@ -3,7 +3,7 @@
* found in the LICENSE file.
*/
-/* From private/ppb_nacl_private.idl modified Fri May 30 10:50:23 2014. */
+/* From private/ppb_nacl_private.idl modified Tue Jun 3 08:33:15 2014. */
#ifndef PPAPI_C_PRIVATE_PPB_NACL_PRIVATE_H_
#define PPAPI_C_PRIVATE_PPB_NACL_PRIVATE_H_
@@ -403,11 +403,16 @@ struct PPB_NaCl_Private_1_0 {
struct PP_Var* full_url,
struct PP_PNaClOptions* pnacl_options,
PP_Bool* uses_nonsfi_mode);
- PP_Bool (*ManifestResolveKey)(PP_Instance instance,
- PP_Bool helper_process,
- const char* key,
- struct PP_Var* full_url,
- struct PP_PNaClOptions* pnacl_options);
+ /* Opens a manifest entry for the given instance. If this is for a helper
+ * process, we consult our internal pnacl.json instead of the user-supplied
+ * NMF.
+ * Fails for files which require PNaCl translation.
+ */
+ void (*OpenManifestEntry)(PP_Instance instance,
+ PP_Bool is_helper_process,
+ const char* key,
+ struct PP_NaClFileInfo* file_info,
+ struct PP_CompletionCallback callback);
/* Returns the filenames for the llc and ld tools, parsing that information
* from the file given in |filename|.
*/
@@ -433,12 +438,6 @@ struct PPB_NaCl_Private_1_0 {
const char* url,
struct PP_NaClFileInfo* file_info,
struct PP_CompletionCallback callback);
- /* Downloads a non-nexe file specified in the manifest, and sets |file_info|
- * to corresponding information about the file. */
- void (*DownloadFile)(PP_Instance instance,
- const char* url,
- struct PP_NaClFileInfo* file_info,
- struct PP_CompletionCallback callback);
};
typedef struct PPB_NaCl_Private_1_0 PPB_NaCl_Private;
« no previous file with comments | « ppapi/api/private/ppb_nacl_private.idl ('k') | ppapi/native_client/src/trusted/plugin/service_runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698