Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 302093003: Show the correct resource type when XHR fails in the inspector. (Closed)

Created:
6 years, 6 months ago by yhirano
Modified:
6 years, 6 months ago
Reviewers:
eustas, vsevik, aandrey
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Show the correct resource type when XHR fails in the inspector. Currently an XMLHttpRequest that fails without response is shown as "Other" resource type. This CL fixes the behavior. BUG=294676 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175256

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M LayoutTests/http/tests/inspector/network-preflight-options-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/sdk/NetworkManager.js View 1 chunk +3 lines, -1 line 0 comments Download
M Source/devtools/protocol.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
yhirano
6 years, 6 months ago (2014-05-30 04:32:17 UTC) #1
aandrey
6 years, 6 months ago (2014-05-30 05:51:35 UTC) #2
eustas
not lgtm Not all requests loaded by DocumentThreadableLoader are XHR requests.
6 years, 6 months ago (2014-05-30 08:05:07 UTC) #3
yhirano
I think a request is an XHR request if you find the associated pendingXHRReplayData. Is ...
6 years, 6 months ago (2014-05-30 08:11:41 UTC) #4
eustas
On 2014/05/30 08:11:41, yhirano wrote: > I think a request is an XHR request if ...
6 years, 6 months ago (2014-05-30 08:20:46 UTC) #5
eustas
lgtm you still need owner lgtm.
6 years, 6 months ago (2014-05-30 08:21:05 UTC) #6
vsevik
lgtm
6 years, 6 months ago (2014-06-02 05:52:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/302093003/1
6 years, 6 months ago (2014-06-02 05:52:48 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 08:50:15 UTC) #9
Message was sent while issue was closed. 
Change committed as 175256

Powered by Google App Engine
This is Rietveld 408576698