Source/core/inspector/InspectorResourceAgent.cpp - Issue 302093003: Show the correct resource type when XHR fails in the inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorResourceAgent.cpp

Issue 302093003: Show the correct resource type when XHR fails in the inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/inspector/network-preflight-options-expected.txt ('k') | Source/devtools/front_end/sdk/NetworkManager.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorResourceAgent.cpp

diff --git a/Source/core/inspector/InspectorResourceAgent.cpp b/Source/core/inspector/InspectorResourceAgent.cpp

index d53640c8abffa34e8c78f0130c6e29ee9251fa6a..95f899919a573204fa6e46ebaf728a010bf4f5ef 100644

--- a/Source/core/inspector/InspectorResourceAgent.cpp

+++ b/Source/core/inspector/InspectorResourceAgent.cpp

@@ -432,7 +432,7 @@ void InspectorResourceAgent::didFailLoading(unsigned long identifier, const Reso

{

String requestId = IdentifiersFactory::requestId(identifier);

bool canceled = error.isCancellation();

- m_frontend->loadingFailed(requestId, currentTime(), error.localizedDescription(), canceled ? &canceled : 0);

+ m_frontend->loadingFailed(requestId, currentTime(), InspectorPageAgent::resourceTypeJson(m_resourcesData->resourceType(requestId)), error.localizedDescription(), canceled ? &canceled : 0);

}

void InspectorResourceAgent::scriptImported(unsigned long identifier, const String& sourceString)

@@ -454,6 +454,7 @@ void InspectorResourceAgent::documentThreadableLoaderStartedLoadingForClient(uns

if (it == m_pendingXHRReplayData.end())

return;

+ m_resourcesData->setResourceType(IdentifiersFactory::requestId(identifier), InspectorPageAgent::XHRResource);

XHRReplayData* xhrReplayData = it->value.get();

String requestId = IdentifiersFactory::requestId(identifier);

m_resourcesData->setXHRReplayData(requestId, xhrReplayData);