Issue 302003006: Made gl_tests, angle_unittests, and gles2_conform_test depend on base.isolate.

Issue 302003006: Made gl_tests, angle_unittests, and gles2_conform_test depend on base.isolate. (Closed)

Created:
6 years, 6 months ago by Ken Russell (switch to Gerrit)

Modified:
6 years, 6 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, vmiura, Shannon Woods, nicolascapens

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Made gl_tests, angle_unittests, and gles2_conform_test depend on base.isolate. These executables are failing on Windows in Debug mode, very likely because they're missing the Visual Studio runtime DLLs. BUG=378021 TBR=maruel@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273800

Patch Set 1 #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/angle.isolate	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/angle_unittests.isolate	View		1 chunk	+3 lines, -0 lines	2 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

FYI. Committing TBR'd, NOTRY=true to see the effects on the GPU bots faster.

6 years, 6 months ago (2014-05-30 07:32:00 UTC) #1

Ken Russell (switch to Gerrit)

The CQ bit was checked by kbr@chromium.org

6 years, 6 months ago (2014-05-30 07:32:07 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/302003006/1

6 years, 6 months ago (2014-05-30 07:33:20 UTC) #3

M-A Ruel

https://codereview.chromium.org/302003006/diff/1/chrome/angle_unittests.isolate File chrome/angle_unittests.isolate (right): https://codereview.chromium.org/302003006/diff/1/chrome/angle_unittests.isolate#newcode6 chrome/angle_unittests.isolate:6: '../base/base.isolate', Oh, didn't you want it to include angle.isolate ...

6 years, 6 months ago (2014-05-30 12:28:46 UTC) #6

Ken Russell (switch to Gerrit)

6 years, 6 months ago (2014-05-30 23:27:37 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/302003006/diff/1/chrome/angle_unittests.isolate
File chrome/angle_unittests.isolate (right):

https://codereview.chromium.org/302003006/diff/1/chrome/angle_unittests.isola...
chrome/angle_unittests.isolate:6: '../base/base.isolate',
On 2014/05/30 12:28:47, M-A Ruel wrote:
> Oh, didn't you want it to include angle.isolate instead?

It turned out to not be necessary, so I preferred to add the minimal
dependencies.

Expand Messages | Collapse Messages