Remove IOSurfaceSupport

Remove IOSurfaceSupport

Link against IOSurface.framework instead -- this is an option starting in 10.6.

BUG=314190
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274746

[ccameron, 2014-05-30 20:26:35]

I needed to pull an instance of IOSurfaceSupport into the IO thread in order to
ensure that the IOSurface didn't get freed immediately upon being acked (we're
using a compositor lock to enforce GPU backpressure from the browser process).

This meant making IOSurfaceSupport's initialization and calling thread-safe.
Deleting it was the easier option, since it's only needed for 10.5 and earlier.

[ccameron, 2014-05-30 22:57:52]

On 2014/05/30 20:26:35, ccameron1 wrote:
> I needed to pull an instance of IOSurfaceSupport into the IO thread in order
to
> ensure that the IOSurface didn't get freed immediately upon being acked (we're
> using a compositor lock to enforce GPU backpressure from the browser process).
> 
> This meant making IOSurfaceSupport's initialization and calling thread-safe.
> Deleting it was the easier option, since it's only needed for 10.5 and
earlier.

Wow, the failed compile is a total mystery: if I do

#if defined(OS_MACOSX)
#include <IOSurface/IOSurfaceAPI.h>
#endif

in that location, it fails. If I do it later, it passes. If I just remove the
#if block, it passes. If I change it to an #if 1, it passes. I know that blaming
the compiler is the step before realizing you're a moron, but I really want to
blame the compiler.

[ccameron, 2014-05-30 22:57:53]

On 2014/05/30 20:26:35, ccameron1 wrote:
> I needed to pull an instance of IOSurfaceSupport into the IO thread in order
to
> ensure that the IOSurface didn't get freed immediately upon being acked (we're
> using a compositor lock to enforce GPU backpressure from the browser process).
> 
> This meant making IOSurfaceSupport's initialization and calling thread-safe.
> Deleting it was the easier option, since it's only needed for 10.5 and
earlier.

Wow, the failed compile is a total mystery: if I do

#if defined(OS_MACOSX)
#include <IOSurface/IOSurfaceAPI.h>
#endif

in that location, it fails. If I do it later, it passes. If I just remove the
#if block, it passes. If I change it to an #if 1, it passes. I know that blaming
the compiler is the step before realizing you're a moron, but I really want to
blame the compiler.

[ccameron, 2014-05-30 23:08:42]

On 2014/05/30 22:57:53, ccameron1 wrote:
> On 2014/05/30 20:26:35, ccameron1 wrote:
> > I needed to pull an instance of IOSurfaceSupport into the IO thread in order
> to
> > ensure that the IOSurface didn't get freed immediately upon being acked
(we're
> > using a compositor lock to enforce GPU backpressure from the browser
process).
> > 
> > This meant making IOSurfaceSupport's initialization and calling thread-safe.
> > Deleting it was the easier option, since it's only needed for 10.5 and
> earlier.
> 
> Wow, the failed compile is a total mystery: if I do
> 
> #if defined(OS_MACOSX)
> #include <IOSurface/IOSurfaceAPI.h>
> #endif
> 
> in that location, it fails. If I do it later, it passes. If I just remove the
> #if block, it passes. If I change it to an #if 1, it passes. I know that
blaming
> the compiler is the step before realizing you're a moron, but I really want to
> blame the compiler.

Nm -- the OS_MACOSX #define comes from build_config.h (which wasn't included
yet), not the command line. The #if defined(OS_WIN) line in the file was being
skipped inappropriately.

[Ken Russell (switch to Gerrit), 2014-05-30 23:21:13]

Nice cleanup. LGTM

[ccameron, 2014-06-02 17:35:01]

Thanks!

ben@, can you do an OWNER stamp for the remaining directories?

[Ben Goodger (Google), 2014-06-03 06:25:12]

fewer platform ifdefs -> lgtm

[ccameron, 2014-06-03 07:30:54]

Thanks!

[ccameron, 2014-06-03 07:30:59]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-06-03 07:31:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ccameron@chromium.org/301973010/40001

[commit-bot: I haz the power, 2014-06-03 08:05:57]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-06-03 08:09:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-03 08:09:29]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[ccameron, 2014-06-03 21:08:19]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-06-03 21:10:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ccameron@chromium.org/301973010/60001

[ccameron, 2014-06-04 00:24:00]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-06-04 00:25:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ccameron@chromium.org/301973010/60001

[commit-bot: I haz the power, 2014-06-04 09:25:56]

Change committed as 274746