Issue 301973008: Revert 273757 "Change instances of s.IsCorruption() to leveldb_e..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 301973008: Revert 273757 "Change instances of s.IsCorruption() to leveldb_e..." (Closed)

Created:
6 years, 6 months ago by battre

Modified:
6 years, 6 months ago

Reviewers:
dgrogan

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 273757 "Change instances of s.IsCorruption() to leveldb_e..." Reverting due to several memory leaks. See http://crbug.com/322707#c11 for details. > Change instances of s.IsCorruption() to leveldb_env::IsCorruption(s). > > LevelDB sometimes returns Status::InvalidArgument() when it encounters > corruption. But LevelDB doesn't provide a Status::IsInvalidArgument() > accessor so we need to indirectly detect it. > > This patch revealed that IndexedDBDatabaseOperationTest.CreatePutDelete > had been passing by accident. In order to make it continue to pass, this > patch adds a method to IndexedDBFakeBackingStore. > > BUG=322707 > > Review URL: https://codereview.chromium.org/303073002 TBR=dgrogan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273773

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -30 lines)			Patch
M	trunk/src/content/browser/indexed_db/indexed_db_database.cc	View	16 chunks	+15 lines, -16 lines	0 comments	Download
M	trunk/src/content/browser/indexed_db/indexed_db_factory.cc	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	trunk/src/content/browser/indexed_db/indexed_db_fake_backing_store.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	trunk/src/content/browser/indexed_db/indexed_db_fake_backing_store.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

battre

6 years, 6 months ago (2014-05-30 09:11:16 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r273773 (tree was closed).

Expand Messages | Collapse Messages