Change instances of s.IsCorruption() to leveldb_env::IsCorruption(s)

Change instances of s.IsCorruption() to leveldb_env::IsCorruption(s).

LevelDB sometimes returns Status::InvalidArgument() when it encounters
corruption. But LevelDB doesn't provide a Status::IsInvalidArgument()
accessor so we need to indirectly detect it.

This patch revealed that IndexedDBDatabaseOperationTest.CreatePutDelete
had been passing by accident. In order to make it continue to pass, this
patch adds a method to IndexedDBFakeBackingStore.

BUG=322707
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273757

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274066

[dgrogan, 2014-05-29 02:59:59]

Chris/Josh, could one of you review this?

[cmumford, 2014-05-29 16:58:03]

lgtm

David: What do you think about modifying LevelDB so that the Status object
returned when operating on a corrupt database always returns true when
Status::IsCorruption() is called? Our leveldb_env::IsCorruption() really seems
like a workaround to a LevelDB bug/omission.

[jsbell, 2014-05-29 18:40:59]

lgtm as well. Thanks for catching this!

As discussed offline, should we see about a patch to leveldb as well so this
does get exposed as corruption?

[dgrogan, 2014-05-29 23:09:50]

The CQ bit was checked by dgrogan@chromium.org

[commit-bot: I haz the power, 2014-05-29 23:12:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dgrogan@chromium.org/303073002/1

[commit-bot: I haz the power, 2014-05-30 03:49:23]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)

[commit-bot: I haz the power, 2014-05-30 08:05:42]

Change committed as 273757

[dgrogan, 2014-05-30 17:51:58]

Yeah, I will send Sanjay a patch that changes a few InvalidArgument statuses to
Corruption statuses.

[dgrogan, 2014-05-30 22:20:34]

On 2014/05/29 18:40:59, jsbell wrote:
> lgtm as well. Thanks for catching this!
> 
> As discussed offline, should we see about a patch to leveldb as well so this
> does get exposed as corruption?

That CL is in g3 @68276458. Once chromium's leveldb rolls past that, this
patch's leveldb_env::IsCorruption(s) can be reverted to the faster
s.IsCorruption().

[dgrogan, 2014-05-30 22:21:16]

r? cq?

[jsbell, 2014-05-31 00:00:34]

lgtm

[jsbell, 2014-05-31 00:00:38]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2014-05-31 00:06:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dgrogan@chromium.org/303073002/20001

[commit-bot: I haz the power, 2014-05-31 22:17:57]

Change committed as 274066