Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(63)

Issue 3019593002: Reland of Add full stack tests for MediaCodec.

Created:
2 months, 2 weeks ago by brandtr
Modified:
2 months, 2 weeks ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Add full stack tests for MediaCodec. (patchset #1 id:1 of https://codereview.webrtc.org/3016593002/ ) Reason for revert: Will disable the failing tests and then reland. Original issue's description: > Revert of Add full stack tests for MediaCodec. (patchset #10 id:180001 of https://codereview.webrtc.org/3005253002/ ) > > Reason for revert: > Breaks KitKat/Lollipop perf bots. > > Original issue's description: > > Add full stack tests for MediaCodec encoder. > > > > * Add audio_ prefix to CallTest::{en,de}coder_factory_. > > * Let VideoQualityTest only instantiate encoders using encoder factories. > > * Add HW encoder factories to VideoQualityTest. > > * Add full stack tests: > > - sqcif7 at 30 kbps: MediaCodec and libvpx. > > - 240p10 at 100 kbps: MediaCodec, libvpx, and MediaCodec+libvpx. > > > > BUG=webrtc:8219 > > > > Review-Url: https://codereview.webrtc.org/3005253002 > > Cr-Commit-Position: refs/heads/master@{#19923} > > Committed: https://webrtc.googlesource.com/src/+/2cefac6c1685abfcd7b90fdef8e926f1c2b79bfa > > TBR=sprang@webrtc.org,asapersson@webrtc.org,kjellander@webrtc.org,stefan@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:8219 > > Review-Url: https://codereview.webrtc.org/3016593002 > Cr-Commit-Position: refs/heads/master@{#19926} > Committed: https://webrtc.googlesource.com/src/+/2c30120fac1e1cbdab89e459ac6256d198bf291d TBR=sprang@webrtc.org,asapersson@webrtc.org,kjellander@webrtc.org,stefan@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:8219

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+475 lines, -187 lines) Patch
M BUILD.gn View 2 chunks +9 lines, -1 line 0 comments Download
M call/call_perf_tests.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M modules/video_coding/BUILD.gn View 3 chunks +19 lines, -10 lines 0 comments Download
M test/call_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/call_test.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M video/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M video/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M video/full_stack_tests.cc View 42 chunks +370 lines, -124 lines 0 comments Download
M video/screenshare_loopback.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M video/video_loopback.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M video/video_quality_test.h View 3 chunks +4 lines, -1 line 0 comments Download
M video/video_quality_test.cc View 7 chunks +49 lines, -41 lines 0 comments Download
Trybot results:

Messages

Total messages: 1 (0 generated)
brandtr
2 months, 2 weeks ago (2017-09-29 06:35:04 UTC) #1
Created Reland of Add full stack tests for MediaCodec.

Powered by Google App Engine
This is Rietveld 0eb02b776