Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2274)

Unified Diff: content/renderer/v8_value_converter_impl.h

Issue 301883002: Should provide creation context and isolate for WebArrayConverter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/v8_value_converter_impl.h
diff --git a/content/renderer/v8_value_converter_impl.h b/content/renderer/v8_value_converter_impl.h
index a5288aecd16866828d0eab10b4d84984b5c27ba0..0bb4e4355084910b69a381fd51f27a3892bd58de 100644
--- a/content/renderer/v8_value_converter_impl.h
+++ b/content/renderer/v8_value_converter_impl.h
@@ -44,13 +44,18 @@ class CONTENT_EXPORT V8ValueConverterImpl : public V8ValueConverter {
class FromV8ValueState;
v8::Local<v8::Value> ToV8ValueImpl(v8::Isolate* isolate,
- const base::Value* value) const;
+ v8::Handle<v8::Object> creationContext,
darin (slow to review) 2014/06/10 04:52:01 nit: creation_context
tasak 2014/06/10 05:09:15 Done.
+ const base::Value* value) const;
v8::Handle<v8::Value> ToV8Array(v8::Isolate* isolate,
+ v8::Handle<v8::Object> creationContext,
darin (slow to review) 2014/06/10 04:52:01 ditto
tasak 2014/06/10 05:09:15 Done.
const base::ListValue* list) const;
v8::Handle<v8::Value> ToV8Object(
v8::Isolate* isolate,
+ v8::Handle<v8::Object> creationContext,
const base::DictionaryValue* dictionary) const;
- v8::Handle<v8::Value> ToArrayBuffer(const base::BinaryValue* value) const;
+ v8::Handle<v8::Value> ToArrayBuffer(v8::Isolate* isolate,
+ v8::Handle<v8::Object> creationContext,
darin (slow to review) 2014/06/10 04:52:01 ditto
tasak 2014/06/10 05:09:15 Done.
+ const base::BinaryValue* value) const;
base::Value* FromV8ValueImpl(FromV8ValueState* state,
v8::Handle<v8::Value> value,

Powered by Google App Engine
This is Rietveld 408576698