Should provide creation context and isolate for WebArrayConverter

content/renderer/v8_value_converter_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_V8_VALUE_CONVERTER_IMPL_H_
 #define CONTENT_RENDERER_V8_VALUE_CONVERTER_IMPL_H_
 
 #include <map>
 
 #include "base/basictypes.h"
@@ skipping 26 matching lines @@
   virtual base::Value* FromV8Value(
       v8::Handle<v8::Value> value,
       v8::Handle<v8::Context> context) const OVERRIDE;
 
  private:
   friend class ScopedAvoidIdentityHashForTesting;
 
   class FromV8ValueState;
 
   v8::Local<v8::Value> ToV8ValueImpl(v8::Isolate* isolate,
-                                      const base::Value* value) const;
+                                     v8::Handle<v8::Object> creationContext,

[darin (slow to review), 2014/06/10 04:52:01]

nit: creation_context

[tasak, 2014/06/10 05:09:15]

Done.

+                                     const base::Value* value) const;
   v8::Handle<v8::Value> ToV8Array(v8::Isolate* isolate,
+                                  v8::Handle<v8::Object> creationContext,

[darin (slow to review), 2014/06/10 04:52:01]

ditto

[tasak, 2014/06/10 05:09:15]

Done.

                                   const base::ListValue* list) const;
   v8::Handle<v8::Value> ToV8Object(
       v8::Isolate* isolate,
+      v8::Handle<v8::Object> creationContext,
       const base::DictionaryValue* dictionary) const;
-  v8::Handle<v8::Value> ToArrayBuffer(const base::BinaryValue* value) const;
+  v8::Handle<v8::Value> ToArrayBuffer(v8::Isolate* isolate,
+                                      v8::Handle<v8::Object> creationContext,

[darin (slow to review), 2014/06/10 04:52:01]

ditto

[tasak, 2014/06/10 05:09:15]

Done.

+                                      const base::BinaryValue* value) const;
 
   base::Value* FromV8ValueImpl(FromV8ValueState* state,
                                v8::Handle<v8::Value> value,
                                v8::Isolate* isolate) const;
   base::Value* FromV8Array(v8::Handle<v8::Array> array,
                            FromV8ValueState* state,
                            v8::Isolate* isolate) const;
 
   // This will convert objects of type ArrayBuffer or any of the
   // ArrayBufferView subclasses.
@@ skipping 21 matching lines @@
 
   // Strategy object that changes the converter's behavior.
   Strategy* strategy_;
 
   DISALLOW_COPY_AND_ASSIGN(V8ValueConverterImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_V8_VALUE_CONVERTER_IMPL_H_