During image destroy, delete textures only if we have a GL context.

content/common/gpu/gpu_command_buffer_stub.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
 #include "base/hash.h"
 #include "base/memory/shared_memory.h"
@@ skipping 928 matching lines @@
   if (!image)
     return;
 
   // For Android specific workaround.
   if (context_group_->feature_info()->workarounds().release_image_after_use)
     image->SetReleaseAfterUse();
 
   if (decoder_) {
     gpu::gles2::ImageManager* image_manager = decoder_->GetImageManager();
     DCHECK(image_manager);
-    image_manager->AddImage(image.get(), id);
+    if (!image_manager->AddImage(image.get(), id))
+      return;

[reveman, 2014/07/30 14:11:12]

I just remembered the second reason to why I prefer the check using LookupImage
from here instead of in the tile manager. If this fails, we now have to create a
GLImage instance and then destroy it. But if the check was done from here we
could check that it's a valid ID before we create the GLImage.

If you keep this as is, then you have to call Destroy on the image here when
adding it fails. However, I would much prefer to not create the image in the
first place if the ID is invalid. sievers@, what do you think?

[no sievers, 2014/07/30 14:46:46]

Normally I'd say it makes more sense to optimize it for the expected case (one
lookup instead of two) than the failure path. However, it's a hash map and the
number of items will be comparably small anyhow (or we have other perf
problems).
So either is totally fine with me. As long as it behaves robustly (see your
other comment), please land. I don't want to delay sohan further by nitpicking
:) This patch is a good improvement.

[sohanjg, 2014/07/30 15:02:44]

thanks :)

   }
 }
 
 void GpuCommandBufferStub::OnDestroyGpuMemoryBuffer(int32 id) {
   TRACE_EVENT0("gpu", "GpuCommandBufferStub::OnDestroyGpuMemoryBuffer");
 
   if (decoder_) {
     gpu::gles2::ImageManager* image_manager = decoder_->GetImageManager();
     DCHECK(image_manager);
     image_manager->RemoveImage(id);
@@ skipping 92 matching lines @@
   if (decoder_)
     decoder_->LoseContext(GL_UNKNOWN_CONTEXT_RESET_ARB);
   command_buffer_->SetParseError(gpu::error::kLostContext);
 }
 
 uint64 GpuCommandBufferStub::GetMemoryUsage() const {
   return GetMemoryManager()->GetClientMemoryUsage(this);
 }
 
 }  // namespace content