Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 3016703002: Fix occassional hang in iOS 11 when calling VTDecompressionSessionInvalidate.

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks ago by jtt_webrtc
Modified:
2 weeks, 6 days ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix occassional hang in iOS 11 when calling VTDecompressionSessionInvalidate. BUG=webrtc:8302

Patch Set 1 #

Patch Set 2 : Wrap change in iOS only define. #

Total comments: 1

Patch Set 3 : Wrap change in iOS only define. #

Patch Set 4 : Wrap change in iOS only define. #

Patch Set 5 : Wrap change in iOS only define. #

Patch Set 6 : Merge branch 'master' of https://chromium.googlesource.com/external/webrtc into hang #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M sdk/objc/Framework/Classes/Common/UIDevice+RTCDevice.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm View 1 2 chunks +10 lines, -1 line 0 comments Download
M sdk/objc/Framework/Headers/WebRTC/UIDevice+RTCDevice.h View 1 chunk +1 line, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 20 (14 generated)
jtt_webrtc
Tried 48 video calls, couldn't repro the hang with the fix while at the same ...
3 weeks ago (2017-09-27 23:52:44 UTC) #2
kthelgason
On 2017/09/27 23:52:44, jtt_webrtc wrote: > Tried 48 video calls, couldn't repro the hang with ...
2 weeks, 6 days ago (2017-09-28 07:24:27 UTC) #11
daniela-webrtc
https://codereview.webrtc.org/3016703002/diff/20001/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm File sdk/objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm (right): https://codereview.webrtc.org/3016703002/diff/20001/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm#newcode242 sdk/objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm:242: VTDecompressionSessionWaitForAsynchronousFrames(_decompressionSession); We should still call `VTDecompressionSessionInvalidate(_decompressionSession);` after this to ...
2 weeks, 6 days ago (2017-09-28 09:55:19 UTC) #13
jtt_webrtc
On 2017/09/28 09:55:19, daniela-webrtc wrote: > https://codereview.webrtc.org/3016703002/diff/20001/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm > File sdk/objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm (right): > > https://codereview.webrtc.org/3016703002/diff/20001/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm#newcode242 > ...
2 weeks, 6 days ago (2017-09-28 15:51:49 UTC) #14
jtt_webrtc
On 2017/09/28 07:24:27, kthelgason wrote: > On 2017/09/27 23:52:44, jtt_webrtc wrote: > > Tried 48 ...
2 weeks, 6 days ago (2017-09-28 16:16:38 UTC) #15
jtt_webrtc
2 weeks, 6 days ago (2017-09-28 17:22:32 UTC) #20
On 2017/09/28 16:16:38, jtt_webrtc wrote:
> On 2017/09/28 07:24:27, kthelgason wrote:
> > On 2017/09/27 23:52:44, jtt_webrtc wrote:
> > > Tried 48 video calls, couldn't repro the hang with the fix while at the
same
> > > time the other side hung 4-5 times (without the fix).
> > 
> > WebRTC has switched over to gerrit, I don't think CLs can still be landed
> here.
> > Please upload a new CL to gerrit :)
> 
> I'm having problems uploading to gerrit - "fatal: remote error: Upload denied
> for project 'external/webrtc'"
> I signed into gerrit but I don't think I have permissions to contribute.

Moved CL to gerrit at https://webrtc-review.googlesource.com/c/src/+/4520
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa