Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 301653003: Now explicitly hanging up in AppRTC test. (Closed)

Created:
6 years, 7 months ago by phoglund_chromium
Modified:
6 years, 7 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Visibility:
Public.

Description

Now explicitly hanging up in AppRTC test. Setting no-try since this test doesn't run on trybots anyway. BUG=373252, 377383 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272952

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc View 3 chunks +17 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
phoglund_chromium
kjellander: main review xians: owner stamp
6 years, 7 months ago (2014-05-27 09:25:13 UTC) #1
kjellander_chromium
lgtm https://codereview.chromium.org/301653003/diff/1/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc File chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc (right): https://codereview.chromium.org/301653003/diff/1/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc#newcode128 chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc:128: "window.domAutomationController.send(remoteVideo.style.opacity)"; We really should have a better way ...
6 years, 7 months ago (2014-05-27 09:47:52 UTC) #2
no longer working on chromium
lgtm
6 years, 7 months ago (2014-05-27 12:13:28 UTC) #3
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 7 months ago (2014-05-27 12:14:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/301653003/1
6 years, 7 months ago (2014-05-27 12:14:29 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 12:45:13 UTC) #6
Message was sent while issue was closed.
Change committed as 272952

Powered by Google App Engine
This is Rietveld 408576698