Now explicitly hanging up in AppRTC test.

chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/files/file_enumerator.h"
 #include "base/path_service.h"
 #include "base/process/launch.h"
 #include "base/rand_util.h"
 #include "base/strings/stringprintf.h"
@@ skipping 104 matching lines @@
     return result == kTitlePageOfAppEngineAdminPage;
   }
 
   bool WaitForCallToComeUp(content::WebContents* tab_contents) {
     // Apprtc will set remoteVideo.style.opacity to 1 when the call comes up.
     std::string javascript =
         "window.domAutomationController.send(remoteVideo.style.opacity)";
     return test::PollingWaitUntil(javascript, "1", tab_contents);
   }
 
+  bool WaitForCallToHangUp(content::WebContents* tab_contents) {
+    // Apprtc will set remoteVideo.style.opacity to 1 when the call comes up.
+    std::string javascript =
+        "window.domAutomationController.send(remoteVideo.style.opacity)";

[kjellander_chromium, 2014/05/27 09:47:52]

We really should have a better way to check this state in case they change
AppRTC's HTML elements, but let's think about that for the future.

+    return test::PollingWaitUntil(javascript, "0", tab_contents);
+  }
+
   bool EvalInJavascriptFile(content::WebContents* tab_contents,
                             const base::FilePath& path) {
     std::string javascript;
     if (!ReadFileToString(path, &javascript)) {
       LOG(ERROR) << "Missing javascript code at " << path.value() << ".";
       return false;
     }
 
     if (!content::ExecuteScript(tab_contents, javascript)) {
       LOG(ERROR) << "Failed to execute the following javascript: " <<
@@ skipping 10 matching lines @@
     if (!EvalInJavascriptFile(tab_contents, GetSourceDir().Append(
         FILE_PATH_LITERAL("chrome/test/data/webrtc/video_detector.js"))))
       return false;
 
     // The remote video tag is called remoteVideo in the AppRTC code.
     StartDetectingVideo(tab_contents, "remoteVideo");
     WaitForVideoToPlay(tab_contents);
     return true;
   }
 
+  bool HangUpApprtcCall(content::WebContents* tab_contents) {
+    // This is the same as clicking the Hangup button in the AppRTC call.
+    return content::ExecuteScript(tab_contents, "onHangup()");
+  }
+
   base::FilePath GetSourceDir() {
     base::FilePath source_dir;
     PathService::Get(base::DIR_SOURCE_ROOT, &source_dir);
     return source_dir;
   }
 
   bool LaunchFirefoxWithUrl(const GURL& url) {
     base::FilePath firefox_binary =
         GetSourceDir().Append(
             FILE_PATH_LITERAL("../firefox-nightly/firefox/firefox"));
@@ skipping 59 matching lines @@
   chrome::AddTabAt(browser(), GURL(), -1, true);
   content::WebContents* left_tab = OpenPageAndAcceptUserMedia(room_url);
   chrome::AddTabAt(browser(), GURL(), -1, true);
   content::WebContents* right_tab = OpenPageAndAcceptUserMedia(room_url);
 
   ASSERT_TRUE(WaitForCallToComeUp(left_tab));
   ASSERT_TRUE(WaitForCallToComeUp(right_tab));
 
   ASSERT_TRUE(DetectRemoteVideoPlaying(left_tab));
   ASSERT_TRUE(DetectRemoteVideoPlaying(right_tab));
+
+  ASSERT_TRUE(HangUpApprtcCall(left_tab));
+
+  ASSERT_TRUE(WaitForCallToHangUp(left_tab));
+  ASSERT_TRUE(WaitForCallToHangUp(right_tab));
 }
 
 #if defined(OS_LINUX)
 #define MAYBE_MANUAL_FirefoxApprtcInteropTest MANUAL_FirefoxApprtcInteropTest
 #else
 // Not implemented yet on Windows and Mac.
 #define MAYBE_MANUAL_FirefoxApprtcInteropTest DISABLED_MANUAL_FirefoxApprtcInteropTest
 #endif
 
 IN_PROC_BROWSER_TEST_F(WebRtcApprtcBrowserTest,
@@ skipping 19 matching lines @@
                                           base::RandInt(0, 65536)));
   content::WebContents* chrome_tab = OpenPageAndAcceptUserMedia(room_url);
 
   ASSERT_TRUE(LaunchFirefoxWithUrl(room_url));
 
   ASSERT_TRUE(WaitForCallToComeUp(chrome_tab));
 
   // Ensure Firefox manages to send video our way.
   ASSERT_TRUE(DetectRemoteVideoPlaying(chrome_tab));
 }