Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: chrome/browser/metrics/metrics_service.h

Issue 301633006: Move ChromeOS hardware class init out of MetricsService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_service.h
diff --git a/chrome/browser/metrics/metrics_service.h b/chrome/browser/metrics/metrics_service.h
index 9af1b4bb817a68c5508cd2b3ebe10bce82fe02fe..5698823c988e682d8ed197fb37befbd4771b25ab 100644
--- a/chrome/browser/metrics/metrics_service.h
+++ b/chrome/browser/metrics/metrics_service.h
@@ -258,14 +258,11 @@ class MetricsService
typedef std::vector<SyntheticTrialGroup> SyntheticTrialGroups;
- // First part of the init task. Called on the FILE thread to load hardware
- // class information.
- static void InitTaskGetHardwareClass(base::WeakPtr<MetricsService> self,
- base::MessageLoopProxy* target_loop);
+ // Calls into the client to start metrics gathering.
+ void StartGatheringMetrics();
- // Callback from InitTaskGetHardwareClass() that continues the init task by
- // loading plugin information.
- void OnInitTaskGotHardwareClass(const std::string& hardware_class);
+ // Callback that continues the init task by loading plugin information.
+ void OnInitTaskGotHardwareClass();
// Called after the Plugin init task has been completed that continues the
// init task by launching a task to gather Google Update statistics.
@@ -443,12 +440,6 @@ class MetricsService
// Whether the initial stability log has been recorded during startup.
bool has_initial_stability_log_;
- // Chrome OS hardware class (e.g., hardware qualification ID). This
- // class identifies the configured system components such as CPU,
- // WiFi adapter, etc. For non Chrome OS hosts, this will be an
- // empty string.
- std::string hardware_class_;
-
#if defined(ENABLE_PLUGINS)
PluginMetricsProvider* plugin_metrics_provider_;
#endif

Powered by Google App Engine
This is Rietveld 408576698