chrome/browser/metrics/metrics_log.cc - Issue 301633006: Move ChromeOS hardware class init out of MetricsService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_log.cc

Issue 301633006: Move ChromeOS hardware class init out of MetricsService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to review Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/chromeos_metrics_provider.cc ('K') | « chrome/browser/metrics/chromeos_metrics_provider.cc ('k') | chrome/browser/metrics/metrics_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/metrics_log.cc

diff --git a/chrome/browser/metrics/metrics_log.cc b/chrome/browser/metrics/metrics_log.cc

index d9e11a823270879c13c0527925ce68a7118c38eb..ba5fdf9ec14a83ccf32ffc00e2d0d35cd37012f3 100644

--- a/chrome/browser/metrics/metrics_log.cc

+++ b/chrome/browser/metrics/metrics_log.cc

@@ -341,6 +341,8 @@ void MetricsLog::RecordEnvironment(

system_profile->set_application_locale(client_->GetApplicationLocale());

+ // By default, the hardware class is empty (i.e., unknown).

+ set_hardware_class("");

Alexei Svitkine (slow) 2014/05/28 15:50:10 Nit: Inline set_hardware_class() and remove that m

blundell 2014/05/28 18:39:35 Done.

SystemProfileProto::Hardware* hardware = system_profile->mutable_hardware();

hardware->set_cpu_architecture(base::SysInfo::OperatingSystemArchitecture());

hardware->set_system_ram_mb(base::SysInfo::AmountOfPhysicalMemoryMB());