Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issue 301633005: Merge Debugger and Debug. (Closed)

Created:
6 years, 7 months ago by Yang
Modified:
6 years, 7 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+509 lines, -542 lines) Patch
M src/api.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M src/arm/assembler-arm.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/arm/debug-arm.cc View 12 chunks +15 lines, -14 lines 0 comments Download
M src/arm64/assembler-arm64.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/arm64/debug-arm64.cc View 13 chunks +17 lines, -16 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M src/compiler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/debug.h View 10 chunks +292 lines, -308 lines 0 comments Download
M src/debug.cc View 32 chunks +84 lines, -101 lines 0 comments Download
M src/execution.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/full-codegen.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/debug-ia32.cc View 12 chunks +15 lines, -14 lines 0 comments Download
M src/isolate.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/isolate.cc View 3 chunks +1 line, -4 lines 0 comments Download
M src/liveedit.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mips/debug-mips.cc View 12 chunks +15 lines, -14 lines 0 comments Download
M src/runtime.cc View 14 chunks +14 lines, -14 lines 0 comments Download
M src/x64/debug-x64.cc View 12 chunks +15 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 7 months ago (2014-05-27 12:31:56 UTC) #1
ulan
lgtm, thanks for splitting the CL.
6 years, 7 months ago (2014-05-27 12:35:18 UTC) #2
Yang
6 years, 7 months ago (2014-05-27 13:21:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21524 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698