Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Issue 301633004: reland 260073013: Added automatic mode to FakeInputAudioStream to generate automatic beeps (Closed)

Created:
6 years, 7 months ago by no longer working on chromium
Modified:
6 years, 7 months ago
Reviewers:
Henrik Grunell
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

reland 260073013: Added automatic mode to FakeInputAudioStream to generate automatic beeps Added automatic mode to FakeInputAudioStream to generate automatic beeps. This patch is to allow writing audio only tests using the fake input stream, also it changes the name of the fake device from "Default" to "Fake Audio", which I hope it will make things less confusing. NOTRY=true TBR=grunell@chromium.org BUG=358541 TEST=bots existing webrtc tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272964

Patch Set 1 #

Patch Set 2 : fixed ML and verified things work. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -68 lines) Patch
M content/browser/renderer_host/media/audio_input_device_manager.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_device_manager.cc View 1 5 chunks +23 lines, -28 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_device_manager_unittest.cc View 8 chunks +1 line, -20 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/audio/fake_audio_input_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/audio/fake_audio_input_stream.cc View 5 chunks +33 lines, -14 lines 0 comments Download
M media/audio/mock_audio_manager.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 7 months ago (2014-05-27 08:34:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/301633004/20001
6 years, 7 months ago (2014-05-27 08:35:03 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 08:35:04 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-27 08:35:04 UTC) #4
Henrik Grunell
LGTM on the fix patch set 1->2.
6 years, 7 months ago (2014-05-27 09:04:55 UTC) #5
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 7 months ago (2014-05-27 09:08:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/301633004/20001
6 years, 7 months ago (2014-05-27 09:09:08 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-27 11:18:40 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 11:27:02 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77854)
6 years, 7 months ago (2014-05-27 11:27:03 UTC) #10
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 7 months ago (2014-05-27 13:51:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/301633004/20001
6 years, 7 months ago (2014-05-27 13:52:02 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 13:53:02 UTC) #13
Message was sent while issue was closed.
Change committed as 272964

Powered by Google App Engine
This is Rietveld 408576698