Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: chrome/browser/favicon/favicon_tab_helper.h

Issue 301613004: Turn FaviconClient into a Keyed service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: touching wood Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_
6 #define CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_ 6 #define CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 content::NavigationController::ReloadType reload_type) OVERRIDE; 100 content::NavigationController::ReloadType reload_type) OVERRIDE;
101 virtual void DidNavigateMainFrame( 101 virtual void DidNavigateMainFrame(
102 const content::LoadCommittedDetails& details, 102 const content::LoadCommittedDetails& details,
103 const content::FrameNavigateParams& params) OVERRIDE; 103 const content::FrameNavigateParams& params) OVERRIDE;
104 104
105 // Helper method that returns the active navigation entry's favicon. 105 // Helper method that returns the active navigation entry's favicon.
106 content::FaviconStatus& GetFaviconStatus(); 106 content::FaviconStatus& GetFaviconStatus();
107 107
108 Profile* profile_; 108 Profile* profile_;
109 109
110 scoped_ptr<FaviconClient> client_; 110 FaviconClient* client_;
111 111
112 std::vector<content::FaviconURL> favicon_urls_; 112 std::vector<content::FaviconURL> favicon_urls_;
113 113
114 scoped_ptr<FaviconHandler> favicon_handler_; 114 scoped_ptr<FaviconHandler> favicon_handler_;
115 115
116 // Handles downloading touchicons. It is NULL if 116 // Handles downloading touchicons. It is NULL if
117 // browser_defaults::kEnableTouchIcon is false. 117 // browser_defaults::kEnableTouchIcon is false.
118 scoped_ptr<FaviconHandler> touch_icon_handler_; 118 scoped_ptr<FaviconHandler> touch_icon_handler_;
119 119
120 DISALLOW_COPY_AND_ASSIGN(FaviconTabHelper); 120 DISALLOW_COPY_AND_ASSIGN(FaviconTabHelper);
121 }; 121 };
122 122
123 #endif // CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_ 123 #endif // CHROME_BROWSER_FAVICON_FAVICON_TAB_HELPER_H_
OLDNEW
« no previous file with comments | « chrome/browser/favicon/chrome_favicon_client_factory.cc ('k') | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698