Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 301603005: Unflake and speedup JsNative*Sample cpu profile tests (Closed)

Created:
6 years, 7 months ago by alph
Modified:
6 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Unflake and speedup JsNative*Sample cpu profile tests Instead of running cpu profiler for a hundred milliseconds, collecting samples distributed in a non-deterministic way all along the code, make the tests rely on a single sample we collect on the profiler start. R=bmeurer@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22345

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comment. #

Patch Set 3 : Rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -109 lines) Patch
M src/profile-generator.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/cctest.status View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 2 8 chunks +51 lines, -102 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
alph
6 years, 7 months ago (2014-05-27 14:20:00 UTC) #1
yurys
https://codereview.chromium.org/301603005/diff/1/test/cctest/test-cpu-profiler.cc File test/cctest/test-cpu-profiler.cc (right): https://codereview.chromium.org/301603005/diff/1/test/cctest/test-cpu-profiler.cc#newcode404 test/cctest/test-cpu-profiler.cc:404: unsigned min_js_samples, bool start_profile = true, You can return ...
6 years, 7 months ago (2014-05-27 14:38:19 UTC) #2
alph
https://codereview.chromium.org/301603005/diff/1/test/cctest/test-cpu-profiler.cc File test/cctest/test-cpu-profiler.cc (right): https://codereview.chromium.org/301603005/diff/1/test/cctest/test-cpu-profiler.cc#newcode404 test/cctest/test-cpu-profiler.cc:404: unsigned min_js_samples, bool start_profile = true, On 2014/05/27 14:38:19, ...
6 years, 7 months ago (2014-05-27 14:46:54 UTC) #3
yurys
lgtm
6 years, 7 months ago (2014-05-27 14:48:14 UTC) #4
alph
ptal
6 years, 6 months ago (2014-05-28 12:06:42 UTC) #5
Benedikt Meurer
LGTM
6 years, 6 months ago (2014-06-23 04:51:50 UTC) #6
alph
6 years, 5 months ago (2014-07-11 09:06:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r22345 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698