Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: src/profile-generator.cc

Issue 301603005: Unflake and speedup JsNative*Sample cpu profile tests (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebaseline Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/cctest.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/profile-generator.cc
diff --git a/src/profile-generator.cc b/src/profile-generator.cc
index 945bdd6cc12f5ea883ea6a30a12c24f938b81de2..44f7555b350cfeff8f078ac0da75fa75f09547fd 100644
--- a/src/profile-generator.cc
+++ b/src/profile-generator.cc
@@ -469,9 +469,10 @@ bool CpuProfilesCollection::StartProfiling(const char* title,
}
for (int i = 0; i < current_profiles_.length(); ++i) {
if (strcmp(current_profiles_[i]->title(), title) == 0) {
- // Ignore attempts to start profile with the same title.
+ // Ignore attempts to start profile with the same title...
current_profiles_semaphore_.Signal();
- return false;
+ // ... though return true to force it collect a sample.
+ return true;
}
}
current_profiles_.Add(new CpuProfile(title, record_samples));
« no previous file with comments | « no previous file | test/cctest/cctest.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698