Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 3015703002: Splitting cl https://codereview.webrtc.org/3011373002 into two: updating v1.7 and adding unit tests… (Closed)

Created:
12 months ago by ssilkin
Modified:
11 months, 4 weeks ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Splitting cl https://codereview.webrtc.org/3011373002 into two: updating v1.7 and adding unit tests. This one is about unit test for single-nalu mode: test enables the mode, sets limit for nalu lenght and verifies that encoder follows that limit. I found that QP jumps significantly when single-nalu mode is enabled. In result encoder produces 4kbyte and 0.4kbyte frames back-to-back. But it seems that happens only to couple of frames in the beginning. This caused test to fail with default RC thresholds. To bypass this I increased frame size mismatch threshold from 20 to 30%. This should be Ok considering single-nalu mode is rare. updated OpenH264 to v1.7.0 to fix issue (https://bugs.chromium.org/p/webrtc/issues/detail?id=8070) in adaptive quantization BUG=

Patch Set 1 #

Powered by Google App Engine
This is Rietveld 408576698