Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 301373002: android: Support host multilib builds. (Closed)

Created:
5 years, 3 months ago by Torne
Modified:
5 years ago
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

android: Support host multilib builds. The Android build system now supports multilib 32/64-bit host builds as well as target builds, and Chromium needs to make use of this to properly support compiling V8 for host. Introduce a GYP_HOST_VAR_PREFIX variable that works equivalently to GYP_VAR_PREFIX and use it in all the places where the first/second host architecture must be selected, and also introduce GYP_HOST_MULTILIB to enable the top level makefile to specify whether it wants 32-bit or 64-bit host binaries. BUG=chromium:358141 r1970

Patch Set 1 #

Patch Set 2 : Add test case #

Patch Set 3 : Fix build warning in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -12 lines) Patch
M pylib/gyp/generator/android.py View 1 6 chunks +12 lines, -7 lines 0 comments Download
A + test/android/32or64.c View 1 2 1 chunk +6 lines, -5 lines 0 comments Download
A test/android/gyptest-host-multilib.py View 1 1 chunk +32 lines, -0 lines 0 comments Download
A test/android/host_32or64.gyp View 1 1 chunk +38 lines, -0 lines 0 comments Download
A test/android/writefile.c View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Torne
Anyone on gyp-developer able to review this? I need this change to unblock the android ...
5 years, 3 months ago (2014-06-02 12:51:37 UTC) #1
Torne
Hi Nico, I've added a (simple) test case for this functionality: it tests that it ...
5 years, 2 months ago (2014-06-30 11:28:42 UTC) #2
Torne
OK, so it fails "as expected", namely that both attempts build (the same) 32-bit binary ...
5 years, 2 months ago (2014-06-30 11:46:03 UTC) #3
Torne
If we can land https://codereview.chromium.org/426783004/ then the test here should work correctly, however that CL ...
5 years, 1 month ago (2014-08-08 17:08:29 UTC) #4
Primiano Tucci (use gerrit)
FWIW, LGTM Not a gyp owner nor really familiar with the android generator, but the ...
5 years ago (2014-08-22 16:52:34 UTC) #5
Torne
Hooray! The test now passes thanks to Primiano's test harness fixes in https://codereview.chromium.org/493743002 so it's ...
5 years ago (2014-08-22 16:58:05 UTC) #6
Nico
lgtm Thanks!!
5 years ago (2014-08-25 01:18:05 UTC) #7
Primiano Tucci (use gerrit)
5 years ago (2014-08-25 17:56:09 UTC) #8
Message was sent while issue was closed.
Nico landed this manually in r1970 (Thanks)

Powered by Google App Engine
This is Rietveld 408576698