|
|
Created:
6 years, 6 months ago by Denis Kuznetsov (DE-MUC) Modified:
6 years, 6 months ago CC:
chromium-reviews, pam+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionFix parameters order.
BUG=378338
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274476
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix comment #Messages
Total messages: 15 (0 generated)
LGTM. Thanks for catching this.
The CQ bit was checked by bartfab@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/301353008/1
The CQ bit was unchecked by bartfab@chromium.org
https://codereview.chromium.org/301353008/diff/1/chrome/browser/chromeos/logi... File chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc (right): https://codereview.chromium.org/301353008/diff/1/chrome/browser/chromeos/logi... chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc:275: std::string(), // No need for salt, key's already hashed. Actually, the original comment was correct: The Key class is meant to store the salt, even if the key is hashed already. Since you store the salt elsewhere, std::string() is passed here as an exception.
https://chromiumcodereview.appspot.com/301353008/diff/1/chrome/browser/chrome... File chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc (right): https://chromiumcodereview.appspot.com/301353008/diff/1/chrome/browser/chrome... chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc:275: std::string(), // No need for salt, key's already hashed. On 2014/06/02 16:35:20, bartfab wrote: > Actually, the original comment was correct: The Key class is meant to store the > salt, even if the key is hashed already. Since you store the salt elsewhere, > std::string() is passed here as an exception. Done.
The CQ bit was checked by antrim@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/301353008/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
The CQ bit was checked by nkostylev@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/301353008/20001
Message was sent while issue was closed.
Change committed as 274476 |