Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 301353008: Fix parameters order. (Closed)

Created:
6 years, 6 months ago by Denis Kuznetsov (DE-MUC)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, pam+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Denis Kuznetsov (DE-MUC)
6 years, 6 months ago (2014-06-02 15:11:50 UTC) #1
bartfab (slow)
LGTM. Thanks for catching this.
6 years, 6 months ago (2014-06-02 16:33:50 UTC) #2
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 6 months ago (2014-06-02 16:34:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/301353008/1
6 years, 6 months ago (2014-06-02 16:34:28 UTC) #4
bartfab (slow)
The CQ bit was unchecked by bartfab@chromium.org
6 years, 6 months ago (2014-06-02 16:34:33 UTC) #5
bartfab (slow)
https://codereview.chromium.org/301353008/diff/1/chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc File chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc (right): https://codereview.chromium.org/301353008/diff/1/chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc#newcode275 chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc:275: std::string(), // No need for salt, key's already hashed. ...
6 years, 6 months ago (2014-06-02 16:35:19 UTC) #6
Denis Kuznetsov (DE-MUC)
https://chromiumcodereview.appspot.com/301353008/diff/1/chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc File chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc (right): https://chromiumcodereview.appspot.com/301353008/diff/1/chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc#newcode275 chrome/browser/chromeos/login/managed/managed_user_creation_controller_new.cc:275: std::string(), // No need for salt, key's already hashed. ...
6 years, 6 months ago (2014-06-02 16:39:28 UTC) #7
Denis Kuznetsov (DE-MUC)
The CQ bit was checked by antrim@chromium.org
6 years, 6 months ago (2014-06-02 16:39:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/301353008/20001
6 years, 6 months ago (2014-06-02 16:40:24 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-02 21:55:27 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 22:57:24 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/22745)
6 years, 6 months ago (2014-06-02 22:57:24 UTC) #12
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 6 months ago (2014-06-03 10:12:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/301353008/20001
6 years, 6 months ago (2014-06-03 10:13:28 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 12:11:58 UTC) #15
Message was sent while issue was closed.
Change committed as 274476

Powered by Google App Engine
This is Rietveld 408576698