Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: telemetry/telemetry/internal/backends/chrome_inspector/inspector_serviceworker.py

Issue 3013263002: Handle error code METHOD_NOT_FOUND_CODE in InspectorServiceWorker.StopAllWorkers() (Closed)
Patch Set: raise NotImplementedError Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/backends/chrome_inspector/inspector_serviceworker.py
diff --git a/telemetry/telemetry/internal/backends/chrome_inspector/inspector_serviceworker.py b/telemetry/telemetry/internal/backends/chrome_inspector/inspector_serviceworker.py
index 304a535892d6f798d690adaff67a6dee1d2aac39..a5d0b7266d4d8d614bcbaaafe4137c30d6a00336 100644
--- a/telemetry/telemetry/internal/backends/chrome_inspector/inspector_serviceworker.py
+++ b/telemetry/telemetry/internal/backends/chrome_inspector/inspector_serviceworker.py
@@ -2,12 +2,12 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+from telemetry.internal.backends.chrome_inspector import inspector_websocket
from telemetry.core import exceptions
-
class InspectorServiceWorker(object):
- def __init__(self, inspector_websocket, timeout):
- self._websocket = inspector_websocket
+ def __init__(self, inspector_socket, timeout):
+ self._websocket = inspector_socket
self._websocket.RegisterDomain('ServiceWorker', self._OnNotification)
# ServiceWorker.enable RPC must be called before calling any other methods
# in ServiceWorker domain.
@@ -25,4 +25,9 @@ class InspectorServiceWorker(object):
res = self._websocket.SyncRequest(
{'method': 'ServiceWorker.stopAllWorkers'}, timeout)
if 'error' in res:
+ code = res['error']['code']
+ if code == inspector_websocket.InspectorWebsocket.METHOD_NOT_FOUND_CODE:
+ raise NotImplementedError(
+ 'DevTools method ServiceWorker.stopAllWorkers is not supported by '
+ 'this browser.')
raise exceptions.StoryActionError(res['error']['message'])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698