Handle error code METHOD_NOT_FOUND_CODE in InspectorServiceWorker.StopAllWorkers()

Handle error code METHOD_NOT_FOUND_CODE in InspectorServiceWorker.StopAllWorkers()

DevTools method ServiceWorker.stopAllWorkers is supported from M63, so
calling this can return METHOD_NOT_FOUND_CODE error in previous browser.
This CL make InspectorServiceWorker.StopAllWorkers() handle this error.
If it receives this error, it raises NotImplementedError.

This is implemented in the same way with memory_backend.py does.
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/memory_backend.py?type=cs&q=warn+file:%5Esrc/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/+package:%5Echromium$&l=84

BUG=chromium:736697
Review-Url: https://chromiumcodereview.appspot.com/3013263002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0ce28daf74ebff5a087ccda7db9d6bcfc77dfdf6

[yukiy, 2017-09-27 03:37:12]

Description was changed from

==========
Handle error code METHOD_NOT_FOUND_CODE in
InspectorServiceWorker.StopAllWorkers()

DevTools method ServiceWorker.stopAllWorkers is supported from M63, so
calling this can return METHOD_NOT_FOUND_CODE error in previous browser.
This CL make InspectorServiceWorker.StopAllWorkers() handle this error.
If it receives this error, it only warn and test will be continued.

BUG=chromium:736697
==========

to

==========
Handle error code METHOD_NOT_FOUND_CODE in
InspectorServiceWorker.StopAllWorkers()

DevTools method ServiceWorker.stopAllWorkers is supported from M63, so
calling this can return METHOD_NOT_FOUND_CODE error in previous browser.
This CL make InspectorServiceWorker.StopAllWorkers() handle this error.
If it receives this error, it only warn and test will be continued.

This is implemented in the same way with memory_backend.py does.
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...

BUG=chromium:736697
==========

[yukiy, 2017-09-27 03:40:39]

yukiy@google.com changed reviewers:
+ kouhei@chromium.org, nednguyen@google.com, shimazu@chromium.org

[yukiy, 2017-09-27 03:40:40]

After this CL committed, InspectorServiceWorker.StopAllWorkers() can be also
used in tests on browsers which do not support this devtools method.
PTAL

[shimazu, 2017-09-27 03:50:11]

lgtm

https://codereview.chromium.org/3013263002/diff/1/telemetry/telemetry/interna...
File
telemetry/telemetry/internal/backends/chrome_inspector/inspector_serviceworker.py
(right):

https://codereview.chromium.org/3013263002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/backends/chrome_inspector/inspector_serviceworker.py:32:
# ServiceWorker.stopAllWorkers is suppoted from M63.
nit: supported

[kouhei (in TOK), 2017-09-27 03:52:08]

lgtm

[nednguyen, 2017-09-27 06:57:56]

https://codereview.chromium.org/3013263002/diff/20001/telemetry/telemetry/int...
File
telemetry/telemetry/internal/backends/chrome_inspector/inspector_serviceworker.py
(right):

https://codereview.chromium.org/3013263002/diff/20001/telemetry/telemetry/int...
telemetry/telemetry/internal/backends/chrome_inspector/inspector_serviceworker.py:33:
logging.warning(
We should throw NotImplementedError here: fail hard instead of fail silently.
Most people won't look at log to notice that the test doesn't work the way they
think. 

You can then disable the failing test in other CL with
@decorators.Disabled('reference')

[nednguyen, 2017-09-27 06:58:14]

lgtm so you can land this after changing it to throw execption

[yukiy, 2017-09-27 07:56:10]

Description was changed from

==========
Handle error code METHOD_NOT_FOUND_CODE in
InspectorServiceWorker.StopAllWorkers()

DevTools method ServiceWorker.stopAllWorkers is supported from M63, so
calling this can return METHOD_NOT_FOUND_CODE error in previous browser.
This CL make InspectorServiceWorker.StopAllWorkers() handle this error.
If it receives this error, it only warn and test will be continued.

This is implemented in the same way with memory_backend.py does.
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...

BUG=chromium:736697
==========

to

==========
Handle error code METHOD_NOT_FOUND_CODE in
InspectorServiceWorker.StopAllWorkers()

DevTools method ServiceWorker.stopAllWorkers is supported from M63, so
calling this can return METHOD_NOT_FOUND_CODE error in previous browser.
This CL make InspectorServiceWorker.StopAllWorkers() handle this error.
If it receives this error, it raises NotImplementedError.

This is implemented in the same way with memory_backend.py does.
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...

BUG=chromium:736697
==========

[yukiy, 2017-09-27 07:56:29]

The CQ bit was checked by yukiy@google.com

[yukiy, 2017-09-27 07:56:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
shimazu@chromium.org, kouhei@chromium.org, nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/3013263002/#ps40001
(title: "raise NotImplementedError")

[commit-bot: I haz the power, 2017-09-27 07:56:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-27 08:28:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1506498989018650,
"parent_rev": "1b6b78dad5017a6279f9f02a5531a1b2d993358b", "commit_rev":
"0ce28daf74ebff5a087ccda7db9d6bcfc77dfdf6"}

[commit-bot: I haz the power, 2017-09-27 08:28:53]

Description was changed from

==========
Handle error code METHOD_NOT_FOUND_CODE in
InspectorServiceWorker.StopAllWorkers()

DevTools method ServiceWorker.stopAllWorkers is supported from M63, so
calling this can return METHOD_NOT_FOUND_CODE error in previous browser.
This CL make InspectorServiceWorker.StopAllWorkers() handle this error.
If it receives this error, it raises NotImplementedError.

This is implemented in the same way with memory_backend.py does.
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...

BUG=chromium:736697
==========

to

==========
Handle error code METHOD_NOT_FOUND_CODE in
InspectorServiceWorker.StopAllWorkers()

DevTools method ServiceWorker.stopAllWorkers is supported from M63, so
calling this can return METHOD_NOT_FOUND_CODE error in previous browser.
This CL make InspectorServiceWorker.StopAllWorkers() handle this error.
If it receives this error, it raises NotImplementedError.

This is implemented in the same way with memory_backend.py does.
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...

BUG=chromium:736697

Review-Url: https://chromiumcodereview.appspot.com/3013263002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-09-27 08:28:54]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...