Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 3013123002: Remove unnecessary audio references in PeerConnectionFactory

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by magjed_webrtc
Modified:
2 weeks, 6 days ago
Reviewers:
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unnecessary audio references in PeerConnectionFactory We currently pass in a lot of audio parameters to PeerConnectionFactory which we never use. This CL removes them. All these parameters are reference counted, so they are not needed for lifetime management (unless we do something crazy). Even if we want to switch from reference counting to std::unique_ptrs in the future, the voice engine is a more suitable owner than PeerConnectionFactory. The PeerConnectionFactory already owns a MediaEngine which in turn owns a VoiceEngine. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -57 lines) Patch
M api/peerconnectioninterface.h View 1 chunk +0 lines, -4 lines 0 comments Download
M pc/createpeerconnectionfactory.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M pc/peerconnectionfactory.h View 3 chunks +0 lines, -11 lines 0 comments Download
M pc/peerconnectionfactory.cc View 3 chunks +2 lines, -15 lines 0 comments Download
M pc/peerconnectioninterface_unittest.cc View 2 chunks +1 line, -11 lines 0 comments Download
M pc/test/mock_peerconnection.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sdk/android/src/jni/pc/peerconnectionfactory_jni.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M sdk/objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory.mm View 1 chunk +0 lines, -4 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 5 (4 generated)
guptaromi2529
2 weeks, 6 days ago (2017-09-28 04:52:05 UTC) #5
On 2017/09/15 15:01:23, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   presubmit on master.tryserver.webrtc (JOB_FAILED,
> http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/21739)

http://dollartopoundmoney.com/
http://dollartopoundmoney.com/pound-to-dollar-converter/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa