Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 301283003: Revert "Revert of setConfig -> setInfo (https://codereview.chromium.org/308683005/)" (Closed)

Created:
6 years, 6 months ago by reed1
Modified:
6 years, 6 months ago
Reviewers:
scroggo, robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert "Revert of setConfig -> setInfo (https://codereview.chromium.org/308683005/)" This reverts commit eecaea4148805834f223681f70b6488ceba12d09. TBR= Committed: http://code.google.com/p/skia/source/detail?r=14989

Patch Set 1 #

Patch Set 2 : fix WIC codec, replace setConfig callers in src/core #

Patch Set 3 : update xpsdevice #

Patch Set 4 : add guard for android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -123 lines) Patch
M dm/DMGpuGMTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMWriteTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gmmain.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/common_conditions.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkBitmap.h View 1 chunk +7 lines, -1 line 0 comments Download
M src/core/SkBitmap.cpp View 1 2 3 12 chunks +16 lines, -17 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapScaler.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkDraw.cpp View 1 2 3 3 chunks +6 lines, -8 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkMipMap.cpp View 1 4 chunks +11 lines, -12 lines 0 comments Download
M src/core/SkReadBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkScalerContext.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M src/core/SkValidationUtils.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPictureUtils.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/image/SkImagePriv.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/image/SkSurface_Raster.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/images/SkImageDecoder_libwebp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/images/SkImageRef.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/lazy/SkCachingPixelRef.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/lazy/SkDiscardablePixelRef.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkImageDecoder_CG.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkImageDecoder_WIC.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkGatherPixelRefsAndRects.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/utils/SkPictureUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/views/sdl/SkOSWindow_SDL.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M tests/BitmapCopyTest.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/BitmapTest.cpp View 3 chunks +5 lines, -7 lines 0 comments Download
M tests/CanvasTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageDecodingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PictureTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PipeTest.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/ReadPixelsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SerializationTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ShaderOpacityTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/WritePixelsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
reed1
same as orig CL in patch set #1, so need only review subsequent patches
6 years, 6 months ago (2014-05-29 21:27:54 UTC) #1
reed1
6 years, 6 months ago (2014-05-30 12:27:29 UTC) #2
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-05-30 12:40:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/301283003/60001
6 years, 6 months ago (2014-05-30 12:40:33 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 13:26:38 UTC) #5
Message was sent while issue was closed. 
Change committed as 14989

Powered by Google App Engine
This is Rietveld 408576698