Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: components/gcm_driver/gcm_driver_desktop.cc

Issue 301243019: Change to pass by const reference for a couple GCMDriverDesktop methods (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/gcm_driver/gcm_driver_desktop.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/gcm_driver_desktop.cc
diff --git a/components/gcm_driver/gcm_driver_desktop.cc b/components/gcm_driver/gcm_driver_desktop.cc
index d57aa63faeec17e91dbb64944a1635c9568476a6..64224342f1650e456ebaf47cf4a1176250d97c0a 100644
--- a/components/gcm_driver/gcm_driver_desktop.cc
+++ b/components/gcm_driver/gcm_driver_desktop.cc
@@ -746,8 +746,9 @@ void GCMDriverDesktop::SendFinished(const std::string& app_id,
callback.Run(message_id, result);
}
-void GCMDriverDesktop::MessageReceived(const std::string& app_id,
- GCMClient::IncomingMessage message) {
+void GCMDriverDesktop::MessageReceived(
+ const std::string& app_id,
+ const GCMClient::IncomingMessage& message) {
DCHECK(ui_thread_->RunsTasksOnCurrentThread());
// Drop the event if signed out.
@@ -790,7 +791,7 @@ void GCMDriverDesktop::GCMClientReady() {
}
void GCMDriverDesktop::GetGCMStatisticsFinished(
- GCMClient::GCMStatistics stats) {
+ const GCMClient::GCMStatistics& stats) {
DCHECK(ui_thread_->RunsTasksOnCurrentThread());
// Normally request_gcm_statistics_callback_ would not be null.
« no previous file with comments | « components/gcm_driver/gcm_driver_desktop.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698