Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: components/gcm_driver/gcm_driver_desktop.h

Issue 301243019: Change to pass by const reference for a couple GCMDriverDesktop methods (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/gcm_driver/gcm_driver_desktop.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/gcm_driver_desktop.h
diff --git a/components/gcm_driver/gcm_driver_desktop.h b/components/gcm_driver/gcm_driver_desktop.h
index 1a6d8826dbf7a0fdb1cc1007c88332f97b57a3c3..8f9b2912e78b4b8116908d0caa2a45bbc153f0b9 100644
--- a/components/gcm_driver/gcm_driver_desktop.h
+++ b/components/gcm_driver/gcm_driver_desktop.h
@@ -120,13 +120,13 @@ class GCMDriverDesktop : public GCMDriver, public IdentityProvider::Observer {
const std::string& message_id,
GCMClient::Result result);
void MessageReceived(const std::string& app_id,
- GCMClient::IncomingMessage message);
+ const GCMClient::IncomingMessage& message);
void MessagesDeleted(const std::string& app_id);
void MessageSendError(const std::string& app_id,
const GCMClient::SendErrorDetails& send_error_details);
void GCMClientReady();
- void GetGCMStatisticsFinished(GCMClient::GCMStatistics stats);
+ void GetGCMStatisticsFinished(const GCMClient::GCMStatistics& stats);
// Flag to indicate if GCM is enabled.
bool gcm_enabled_;
« no previous file with comments | « no previous file | components/gcm_driver/gcm_driver_desktop.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698