Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 301243019: Change to pass by const reference for a couple GCMDriverDesktop methods (Closed)

Created:
6 years, 6 months ago by jianli
Modified:
6 years, 6 months ago
Reviewers:
fgorski
CC:
chromium-reviews
Visibility:
Public.

Description

Change to pass by const reference for a couple GCMDriverDesktop methods BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274453

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M components/gcm_driver/gcm_driver_desktop.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jianli
6 years, 6 months ago (2014-06-02 22:07:34 UTC) #1
fgorski
lgtm
6 years, 6 months ago (2014-06-02 22:26:15 UTC) #2
jianli
The CQ bit was checked by jianli@chromium.org
6 years, 6 months ago (2014-06-02 22:34:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/301243019/1
6 years, 6 months ago (2014-06-02 22:37:41 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 10:19:13 UTC) #5
Message was sent while issue was closed.
Change committed as 274453

Powered by Google App Engine
This is Rietveld 408576698