Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 301243012: Merge 269819 "views: Terminate the nested message-loop correctly..." (Closed)

Created:
6 years, 6 months ago by sadrul
Modified:
6 years, 6 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Merge 269819 "views: Terminate the nested message-loop correctly..." > views: Terminate the nested message-loop correctly when closing the menu. > > It is possible for a non-menu source to start a nested message loop > (e.g. for dragging a menu-item). So attempting to terminate the current > iteration of the message-loop when the menu is closed can be problematic. > So instead, terminate the message-loop through the DispatcherClient. > > BUG=367850, 372208 > R=sky@chromium.org > > Review URL: https://codereview.chromium.org/279073002 TBR=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274104

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -72 lines) Patch
M ui/views/controls/menu/menu_controller.h View 2 chunks +5 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 1 chunk +11 lines, -9 lines 0 comments Download
A + ui/views/controls/menu/menu_controller_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/views/controls/menu/menu_event_dispatcher_linux.cc View 2 chunks +26 lines, -14 lines 0 comments Download
M ui/views/controls/menu/menu_message_pump_dispatcher_win.cc View 1 chunk +60 lines, -49 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sadrul
6 years, 6 months ago (2014-06-01 02:58:50 UTC) #1
sadrul
6 years, 6 months ago (2014-06-01 03:00:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r274104 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698