Issue 279073002: views: Terminate the nested message-loop correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 279073002: views: Terminate the nested message-loop correctly. (Closed)

Created:
6 years, 7 months ago by sadrul

Modified:
6 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Terminate the nested message-loop correctly when closing the menu. It is possible for a non-menu source to start a nested message loop (e.g. for dragging a menu-item). So attempting to terminate the current iteration of the message-loop when the menu is closed can be problematic. So instead, terminate the message-loop through the DispatcherClient. BUG=367850, 372208 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269819

Patch Set 1 #

Patch Set 2 : windows? #

Patch Set 3 : test #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+268 lines, -83 lines)			Patch
M	ui/views/controls/menu/menu_controller.h	View	1 2	2 chunks	+5 lines, -1 line	0 comments	Download
M	ui/views/controls/menu/menu_controller.cc	View		1 chunk	+11 lines, -9 lines	0 comments	Download
A	ui/views/controls/menu/menu_controller_unittest.cc	View	1 2 3 4 5	1 chunk	+153 lines, -0 lines	0 comments	Download
M	ui/views/controls/menu/menu_event_dispatcher_linux.cc	View		1 chunk	+38 lines, -24 lines	0 comments	Download
M	ui/views/controls/menu/menu_message_pump_dispatcher_win.cc	View	1	1 chunk	+60 lines, -49 lines	0 comments	Download
M	ui/views/views.gyp	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

I have follow-up cleanups in https://codereview.chromium.org/274383002/ and https://codereview.chromium.org/280483003. This particular change may need to be ...

6 years, 7 months ago (2014-05-12 04:40:06 UTC) #1

sadrul

6 years, 7 months ago (2014-05-12 18:15:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #6 manually as r269819 (presubmit successful).

Expand Messages | Collapse Messages