Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(270)

Issue 3012233002: Remove #include of rtc_stream_config.h from rtc_event_log.h (Closed)

Created:
5 months, 1 week ago by eladalon
Modified:
5 months, 1 week ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove #include of rtc_stream_config.h from rtc_event_log.h StreamConfig is not integral to RTC-event logging in general, but rather to specific events. Therefore, the dependency on it should not be exported through rtc_event_log.h. BUG=webrtc:8111

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M webrtc/call/call.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/rtc_tools/event_log_visualizer/analyzer.cc View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 4 (1 generated)
eladalon
PTAL
5 months, 1 week ago (2017-09-13 12:07:27 UTC) #2
terelius
lgtm
5 months, 1 week ago (2017-09-13 12:20:56 UTC) #3
eladalon
5 months, 1 week ago (2017-09-14 14:58:41 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698