Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 301223010: Create listing of game engines with links to packaged app instructions. (Closed)

Created:
6 years, 6 months ago by scheib
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Create listing of game engines with links to packaged app instructions. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274910

Patch Set 1 : #

Total comments: 9

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
A chrome/common/extensions/docs/static/images/swooop.png View Binary file 0 comments Download
A chrome/common/extensions/docs/templates/articles/game_engines.html View 1 1 chunk +39 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/json/apps_sidenav.json View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/json/chrome_sidenav.json View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/templates/public/apps/game_engines.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
scheib
Preview: https://chrome-apps-doc.appspot.com/_patch/301223010/apps/game_engines
6 years, 6 months ago (2014-05-30 20:12:21 UTC) #1
mkearney1
https://codereview.chromium.org/301223010/diff/20001/chrome/common/extensions/docs/templates/articles/game_engines.html File chrome/common/extensions/docs/templates/articles/game_engines.html (right): https://codereview.chromium.org/301223010/diff/20001/chrome/common/extensions/docs/templates/articles/game_engines.html#newcode7 chrome/common/extensions/docs/templates/articles/game_engines.html:7: instructions for producing a packaged app. 'a packaged app' ...
6 years, 6 months ago (2014-05-30 20:52:13 UTC) #2
scheib
https://codereview.chromium.org/301223010/diff/20001/chrome/common/extensions/docs/templates/articles/game_engines.html File chrome/common/extensions/docs/templates/articles/game_engines.html (right): https://codereview.chromium.org/301223010/diff/20001/chrome/common/extensions/docs/templates/articles/game_engines.html#newcode7 chrome/common/extensions/docs/templates/articles/game_engines.html:7: instructions for producing a packaged app. On 2014/05/30 20:52:13, ...
6 years, 6 months ago (2014-06-02 20:33:42 UTC) #3
mkearney1
Do you want to remove the TOC?
6 years, 6 months ago (2014-06-02 21:35:25 UTC) #4
scheib
I'll leave that up to you to decide. It's my hope to have several items ...
6 years, 6 months ago (2014-06-02 21:57:00 UTC) #5
mkearney1
lgtm
6 years, 6 months ago (2014-06-03 21:53:42 UTC) #6
scheib
The CQ bit was checked by scheib@chromium.org
6 years, 6 months ago (2014-06-03 21:58:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/301223010/40001
6 years, 6 months ago (2014-06-03 21:59:46 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 21:59:48 UTC) #9
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-03 21:59:48 UTC) #10
scheib
kalman, I need a committer level reviewer for this doc
6 years, 6 months ago (2014-06-03 23:16:07 UTC) #11
Ken Rockot(use gerrit already)
lgtm
6 years, 6 months ago (2014-06-04 21:19:44 UTC) #12
scheib
The CQ bit was checked by scheib@chromium.org
6 years, 6 months ago (2014-06-04 21:20:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/301223010/40001
6 years, 6 months ago (2014-06-04 21:23:19 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 21:25:53 UTC) #15
Message was sent while issue was closed.
Change committed as 274910

Powered by Google App Engine
This is Rietveld 408576698