Issue 301223009: Fix chrome://history on Android (check whether element is present first).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 301223009: Fix chrome://history on Android (check whether element is present first). (Closed)

Created:
6 years, 6 months ago by Ted C

Modified:
6 years, 6 months ago

Reviewers:
Dan Beam, davidben

CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix chrome://history on Android (check whether element is present first). $('alertOverlay') is null so the call for classList failed. Guard the condition to see if the element exists. BUG=379194 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273956

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/resources/history/history.js	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/301223009/1

6 years, 6 months ago (2014-05-30 18:26:43 UTC) #5

Message was sent while issue was closed.

Change committed as 273956