chrome/browser/resources/history/history.js - Issue 301223009: Fix chrome://history on Android (check whether element is present first).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/history/history.js

Issue 301223009: Fix chrome://history on Android (check whether element is present first). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/history/history.js

diff --git a/chrome/browser/resources/history/history.js b/chrome/browser/resources/history/history.js

index 3a73426aa18ea28747fd67c6939a79e60c90cc38..8a7c30648326da139495bada3d3cf6979be71dda 100644

--- a/chrome/browser/resources/history/history.js

+++ b/chrome/browser/resources/history/history.js

@@ -996,7 +996,8 @@ HistoryView.prototype.positionNotificationBar = function() {

* @private

HistoryView.prototype.clear_ = function() {

- if ($('alertOverlay').classList.contains('showing'))

+ var alertOverlay = $('alertOverlay');

+ if (alertOverlay && alertOverlay.classList.contains('showing'))

hideConfirmationOverlay();

this.resultDiv_.textContent = '';

« no previous file with comments | « no previous file | no next file » | no next file with comments »