Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 301223007: Delete old mini_installer_test. (Closed)

Created:
6 years, 6 months ago by grt (UTC plus 2)
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Delete old mini_installer_test. And run the new Python-driven test_mini_installer on win_rel trybot. BUG=277655 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274260

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1435 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -1 line 3 comments Download
M build/all.gyp View 3 chunks +2 lines, -6 lines 0 comments Download
M chrome/chrome_installer.gypi View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/test/mini_installer_test/installer_path_provider.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/test/mini_installer_test/installer_path_provider.cc View 1 chunk +0 lines, -237 lines 0 comments Download
D chrome/test/mini_installer_test/installer_test_util.h View 1 chunk +0 lines, -88 lines 0 comments Download
D chrome/test/mini_installer_test/installer_test_util.cc View 1 chunk +0 lines, -300 lines 0 comments Download
D chrome/test/mini_installer_test/mini_installer_test_constants.h View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/test/mini_installer_test/mini_installer_test_constants.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/test/mini_installer_test/run_all_unittests.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/test/mini_installer_test/switch_builder.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/test/mini_installer_test/switch_builder.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/test/mini_installer_test/test.cc View 1 chunk +0 lines, -412 lines 0 comments Download
M testing/buildbot/chromium.win.json View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
grt (UTC plus 2)
6 years, 6 months ago (2014-05-30 14:05:29 UTC) #1
Paweł Hajdan Jr.
LGTM https://codereview.chromium.org/301223007/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/301223007/diff/1/PRESUBMIT.py#newcode1430 PRESUBMIT.py:1430: 'test_mini_installer', Note that win_rel is no longer used, ...
6 years, 6 months ago (2014-06-02 09:54:29 UTC) #2
grt (UTC plus 2)
thanks. https://codereview.chromium.org/301223007/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/301223007/diff/1/PRESUBMIT.py#newcode1430 PRESUBMIT.py:1430: 'test_mini_installer', On 2014/06/02 09:54:29, Paweł Hajdan Jr. wrote: ...
6 years, 6 months ago (2014-06-02 10:32:50 UTC) #3
Paweł Hajdan Jr.
https://codereview.chromium.org/301223007/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/301223007/diff/1/PRESUBMIT.py#newcode1430 PRESUBMIT.py:1430: 'test_mini_installer', On 2014/06/02 10:32:51, grt wrote: > On 2014/06/02 ...
6 years, 6 months ago (2014-06-02 11:19:25 UTC) #4
grt (UTC plus 2)
The CQ bit was checked by grt@chromium.org
6 years, 6 months ago (2014-06-02 13:27:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/301223007/1
6 years, 6 months ago (2014-06-02 13:28:28 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 16:44:46 UTC) #7
Message was sent while issue was closed.
Change committed as 274260

Powered by Google App Engine
This is Rietveld 408576698