Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 3012183002: Adding time profiling support to AudioFrame

Created:
1 year, 3 months ago by henrika_webrtc
Modified:
1 year, 2 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding time profiling support to AudioFrame BUG=webrtc:8206

Patch Set 1 #

Total comments: 13
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M webrtc/modules/include/module_common_types.h View 5 chunks +32 lines, -0 lines 13 comments Download
M webrtc/voice_engine/channel.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
henrika_webrtc
PTAL
1 year, 3 months ago (2017-09-12 08:34:58 UTC) #3
hlundin-webrtc
https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module_common_types.h File webrtc/modules/include/module_common_types.h (right): https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module_common_types.h#newcode345 webrtc/modules/include/module_common_types.h:345: void UpdateProfileTime(); Suggest UpdateProfileTimestamp to match variable name. https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module_common_types.h#newcode348 ...
1 year, 3 months ago (2017-09-14 13:34:34 UTC) #4
hlundin-webrtc
+kwiberg, see qq inline. https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module_common_types.h File webrtc/modules/include/module_common_types.h (right): https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module_common_types.h#newcode385 webrtc/modules/include/module_common_types.h:385: // by design. Also, rtc::Optional ...
1 year, 2 months ago (2017-09-14 13:45:39 UTC) #5
henrika_webrtc
Thanks. Moving to new Gerrit CL. https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module_common_types.h File webrtc/modules/include/module_common_types.h (right): https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module_common_types.h#newcode345 webrtc/modules/include/module_common_types.h:345: void UpdateProfileTime(); On ...
1 year, 2 months ago (2017-09-15 13:33:58 UTC) #6
henrika_webrtc
Moved to https://webrtc-review.googlesource.com/c/src/+/1584
1 year, 2 months ago (2017-09-15 13:37:19 UTC) #7
kwiberg-webrtc
https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module_common_types.h File webrtc/modules/include/module_common_types.h (right): https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module_common_types.h#newcode385 webrtc/modules/include/module_common_types.h:385: // by design. Also, rtc::Optional is not used since ...
1 year, 2 months ago (2017-09-15 17:52:30 UTC) #9
guptaromi2529
http://printablecalendartemplates.com/official-business-letter-example/ Find here all templates
1 year, 2 months ago (2017-09-28 04:44:03 UTC) #10
guptaromi2529
1 year, 2 months ago (2017-09-28 04:44:04 UTC) #11

Powered by Google App Engine
This is Rietveld 408576698