Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: telemetry/telemetry/page/cache_temperature_unittest.py

Issue 3011263002: Add cache_temperature state "HOT" (Closed)
Patch Set: use methods for serviceworker in tab Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/page/cache_temperature_unittest.py
diff --git a/telemetry/telemetry/page/cache_temperature_unittest.py b/telemetry/telemetry/page/cache_temperature_unittest.py
index ae73bbd779b250f8bad3c08615e0cb4df9436d26..37bd2acb8069e0d2e842586c33cdef6b922a5af5 100644
--- a/telemetry/telemetry/page/cache_temperature_unittest.py
+++ b/telemetry/telemetry/page/cache_temperature_unittest.py
@@ -98,3 +98,43 @@ class CacheTempeartureTests(browser_test_case.BrowserTestCase):
markers = self.traceMarkers()
self.assertIn('telemetry.internal.warm_cache.start', markers)
self.assertIn('telemetry.internal.warm_cache.end', markers)
+
+ @decorators.Enabled('has tabs')
+ def testEnsureHotAfterColdAndWarmRun(self):
+ with self.captureTrace():
+ story_set = story.StorySet()
+ page = page_module.Page(
+ 'http://google.com', page_set=story_set,
+ cache_temperature=cache_temperature.COLD, name='http://google.com')
+ cache_temperature.EnsurePageCacheTemperature(page, self._browser)
+
+ previous_page = page
+ page = page_module.Page(
+ 'http://google.com', page_set=story_set,
+ cache_temperature=cache_temperature.WARM, name='http://google.com')
+ cache_temperature.EnsurePageCacheTemperature(
+ page, self._browser, previous_page)
+
+ previous_page = page
+ page = page_module.Page(
+ 'http://google.com', page_set=story_set,
+ cache_temperature=cache_temperature.HOT, name='http://google.com')
+ cache_temperature.EnsurePageCacheTemperature(
+ page, self._browser, previous_page)
+
+ markers = self.traceMarkers()
+ self.assertNotIn('telemetry.internal.warm_cache.start', markers)
+
shimazu 2017/09/25 02:30:36 Can you make a test to run HOT after COLD?
yukiy 2017/09/25 06:28:38 Done.
+ @decorators.Enabled('has tabs')
+ @decorators.Disabled('chromeos')
+ def testEnsureHotFromScratch(self):
+ with self.captureTrace():
+ story_set = story.StorySet()
+ page = page_module.Page(
+ 'http://google.com', page_set=story_set,
+ cache_temperature=cache_temperature.HOT, name='http://google.com')
+ cache_temperature.EnsurePageCacheTemperature(page, self._browser)
+
+ markers = self.traceMarkers()
+ self.assertIn('telemetry.internal.warm_cache.start', markers)
shimazu 2017/09/25 02:30:36 Should we expect two telemetry.internal.warm_cache
kouhei (in TOK) 2017/09/25 05:29:53 self.assertEqual(2, markers.count('telemetry.inter
yukiy 2017/09/25 06:28:37 Acknowledged.
yukiy 2017/09/25 06:28:37 Done.
+ self.assertIn('telemetry.internal.warm_cache.end', markers)

Powered by Google App Engine
This is Rietveld 408576698