Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: telemetry/telemetry/page/cache_temperature_unittest.py

Issue 3011263002: Add cache_temperature state "HOT" (Closed)
Patch Set: use methods for serviceworker in tab Created 3 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import contextlib 5 import contextlib
6 6
7 from telemetry import decorators 7 from telemetry import decorators
8 from telemetry import page as page_module 8 from telemetry import page as page_module
9 from telemetry import story 9 from telemetry import story
10 from telemetry.page import cache_temperature 10 from telemetry.page import cache_temperature
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 with self.captureTrace(): 91 with self.captureTrace():
92 story_set = story.StorySet() 92 story_set = story.StorySet()
93 page = page_module.Page( 93 page = page_module.Page(
94 'http://google.com', page_set=story_set, 94 'http://google.com', page_set=story_set,
95 cache_temperature=cache_temperature.WARM, name='http://google.com') 95 cache_temperature=cache_temperature.WARM, name='http://google.com')
96 cache_temperature.EnsurePageCacheTemperature(page, self._browser) 96 cache_temperature.EnsurePageCacheTemperature(page, self._browser)
97 97
98 markers = self.traceMarkers() 98 markers = self.traceMarkers()
99 self.assertIn('telemetry.internal.warm_cache.start', markers) 99 self.assertIn('telemetry.internal.warm_cache.start', markers)
100 self.assertIn('telemetry.internal.warm_cache.end', markers) 100 self.assertIn('telemetry.internal.warm_cache.end', markers)
101
102 @decorators.Enabled('has tabs')
103 def testEnsureHotAfterColdAndWarmRun(self):
104 with self.captureTrace():
105 story_set = story.StorySet()
106 page = page_module.Page(
107 'http://google.com', page_set=story_set,
108 cache_temperature=cache_temperature.COLD, name='http://google.com')
109 cache_temperature.EnsurePageCacheTemperature(page, self._browser)
110
111 previous_page = page
112 page = page_module.Page(
113 'http://google.com', page_set=story_set,
114 cache_temperature=cache_temperature.WARM, name='http://google.com')
115 cache_temperature.EnsurePageCacheTemperature(
116 page, self._browser, previous_page)
117
118 previous_page = page
119 page = page_module.Page(
120 'http://google.com', page_set=story_set,
121 cache_temperature=cache_temperature.HOT, name='http://google.com')
122 cache_temperature.EnsurePageCacheTemperature(
123 page, self._browser, previous_page)
124
125 markers = self.traceMarkers()
126 self.assertNotIn('telemetry.internal.warm_cache.start', markers)
127
shimazu 2017/09/25 02:30:36 Can you make a test to run HOT after COLD?
yukiy 2017/09/25 06:28:38 Done.
128 @decorators.Enabled('has tabs')
129 @decorators.Disabled('chromeos')
130 def testEnsureHotFromScratch(self):
131 with self.captureTrace():
132 story_set = story.StorySet()
133 page = page_module.Page(
134 'http://google.com', page_set=story_set,
135 cache_temperature=cache_temperature.HOT, name='http://google.com')
136 cache_temperature.EnsurePageCacheTemperature(page, self._browser)
137
138 markers = self.traceMarkers()
139 self.assertIn('telemetry.internal.warm_cache.start', markers)
shimazu 2017/09/25 02:30:36 Should we expect two telemetry.internal.warm_cache
kouhei (in TOK) 2017/09/25 05:29:53 self.assertEqual(2, markers.count('telemetry.inter
yukiy 2017/09/25 06:28:37 Acknowledged.
yukiy 2017/09/25 06:28:37 Done.
140 self.assertIn('telemetry.internal.warm_cache.end', markers)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698