Add ability to look up type parameters that are associated with ClassEntities with the element envi…

Add ability to look up type parameters that are associated with ClassEntities with the element environment.

BUG=

[Emily Fortuna, 2017-09-02 00:52:54]

efortuna@google.com changed reviewers:
+ johnniwinther@google.com

[Emily Fortuna, 2017-09-02 00:52:55]

Suggestion for a different name other than "getTypeVariables" is welcome. :-P

[Johnni Winther, 2017-09-04 06:59:56]

lgtm

https://codereview.chromium.org/3010943002/diff/1/pkg/compiler/lib/src/common...
File pkg/compiler/lib/src/common_elements.dart (right):

https://codereview.chromium.org/3010943002/diff/1/pkg/compiler/lib/src/common...
pkg/compiler/lib/src/common_elements.dart:1358: List<DartType>
getTypeVariables(ClassEntity cls);
[getClassTypeVariables] is probably better since methods can also have type
variables.

https://codereview.chromium.org/3010943002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/3010943002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_impl.dart:258: .map((ir.TypeParameter
type) => getDartType(type.bound));
This is not the correct implementation.

class C<T extends String> {}

for this class [getTypeVariables] would return `[String]` and not `[T]`.

The correct implementation can be implementated directly in the element
environment (see comment below).

https://codereview.chromium.org/3010943002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_impl.dart:1289: :
elementMap.getTypeVariables(irClass);
This method can be implemented using the current interface:

List<DartType> getTypeVariables(ClassEntity cls) =>
    getThisType(cls).typeArguments;

https://codereview.chromium.org/3010943002/diff/1/pkg/compiler/lib/src/ssa/op...
File pkg/compiler/lib/src/ssa/optimize.dart (right):

https://codereview.chromium.org/3010943002/diff/1/pkg/compiler/lib/src/ssa/op...
pkg/compiler/lib/src/ssa/optimize.dart:1222: .length) {
If we replace this by

if (node.inputs.length !=
    _closedWorld.elementEnvironment
        .getThisType(contextClass).typeArguments.length) {

we can avoid the need for the [getTypeVariables] method.

It might be worth having it as a convenience method, though.

[Emily Fortuna, 2017-09-05 17:13:31]

https://codereview.chromium.org/3010943002/diff/1/pkg/compiler/lib/src/common...
File pkg/compiler/lib/src/common_elements.dart (right):

https://codereview.chromium.org/3010943002/diff/1/pkg/compiler/lib/src/common...
pkg/compiler/lib/src/common_elements.dart:1358: List<DartType>
getTypeVariables(ClassEntity cls);
On 2017/09/04 06:59:56, Johnni Winther wrote:
> [getClassTypeVariables] is probably better since methods can also have type
> variables.

Done.

https://codereview.chromium.org/3010943002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/3010943002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_impl.dart:258: .map((ir.TypeParameter
type) => getDartType(type.bound));
On 2017/09/04 06:59:56, Johnni Winther wrote:
> This is not the correct implementation.
> 
> class C<T extends String> {}
> 
> for this class [getTypeVariables] would return `[String]` and not `[T]`.
> 
> The correct implementation can be implementated directly in the element
> environment (see comment below).

Done.

https://codereview.chromium.org/3010943002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_impl.dart:1289: :
elementMap.getTypeVariables(irClass);
On 2017/09/04 06:59:56, Johnni Winther wrote:
> This method can be implemented using the current interface:
> 
> List<DartType> getTypeVariables(ClassEntity cls) =>
>     getThisType(cls).typeArguments;

Done.

https://codereview.chromium.org/3010943002/diff/1/pkg/compiler/lib/src/ssa/op...
File pkg/compiler/lib/src/ssa/optimize.dart (right):

https://codereview.chromium.org/3010943002/diff/1/pkg/compiler/lib/src/ssa/op...
pkg/compiler/lib/src/ssa/optimize.dart:1222: .length) {
On 2017/09/04 06:59:56, Johnni Winther wrote:
> If we replace this by
> 
> if (node.inputs.length !=
>     _closedWorld.elementEnvironment
>         .getThisType(contextClass).typeArguments.length) {
> 
> we can avoid the need for the [getTypeVariables] method.
> 
> It might be worth having it as a convenience method, though.

ah, my mistake. I misunderstood the distinction between typeArguments and type
parameters. Thank you.

[Emily Fortuna, 2017-09-05 17:28:47]

Patchset #2 (id:20001) has been deleted

[Emily Fortuna, 2017-09-05 19:46:35]

Description was changed from

==========
Add ability to look up type parameters that are associated with ClassEntities
with the element environment.

BUG=
==========

to

==========
Add ability to look up type parameters that are associated with ClassEntities
with the element environment.

BUG=
==========